From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B9A9C433E0 for ; Wed, 29 Jul 2020 07:55:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0075D207F5 for ; Wed, 29 Jul 2020 07:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbgG2HzW (ORCPT ); Wed, 29 Jul 2020 03:55:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbgG2HzW (ORCPT ); Wed, 29 Jul 2020 03:55:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9834C061794 for ; Wed, 29 Jul 2020 00:55:21 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0gvj-0007OG-1C; Wed, 29 Jul 2020 09:55:15 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1k0gvh-00055i-Ur; Wed, 29 Jul 2020 09:55:13 +0200 Date: Wed, 29 Jul 2020 09:55:13 +0200 From: Marco Felsch To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Herbert Xu , Dmitry Torokhov , "David S. Miller" , Rob Herring , Shawn Guo , =?iso-8859-1?Q?Andr=E9?= Draszik , Robin Gong , Anson Huang , Fabio Estevam , Aymen Sghaier , Adam Ford , linux-input@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, NXP Linux Team Subject: Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events Message-ID: <20200729075513.ckjnhfv3dxuesvsi@pengutronix.de> References: <20200723074314.3304-1-horia.geanta@nxp.com> <20200723074314.3304-4-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200723074314.3304-4-horia.geanta@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:41:32 up 256 days, 23:00, 248 users, load average: 0.19, 0.11, 0.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 20-07-23 10:43, Horia Geantă wrote: > From: André Draszik > > The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc. > > This driver here should only return IRQ_HANDLED if the status register > indicates that the event we're handling in the irq handler was genuinely > intended for this driver. Otheriwse the interrupt subsystem will > assume the interrupt was handled successfully even though it wasn't > at all. After checking the RM and the imx6qdl.dtsi I'm not very sure that this is right since the snvs-powerkey has a seperate irq-line. So we can be sure that this irq is for us. If this is the case we don't need to check the SNVS_LPSR_REG instead we only need to clear it. Regards, Marco