Linux Input Archive on lore.kernel.org
 help / color / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: nick@shmanahar.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, erosca@de.adit-jv.com,
	Andrew_Gabbasov@mentor.com, digetx@gmail.com
Subject: Re: [PATCH 1/1] Input: atmel_mxt_ts: split large i2c transfers into blocks
Date: Wed, 29 Jul 2020 22:54:53 -0700
Message-ID: <20200730055453.GC1665100@dtor-ws> (raw)
In-Reply-To: <20200729092252.6394-1-jiada_wang@mentor.com>

Hi Jiada,

On Wed, Jul 29, 2020 at 06:22:52PM +0900, Jiada Wang wrote:
> From: Jiada wang <jiada_wang@mentor.com>
> 
> Some I2C controllers constrain maximum transferred data in an I2C
> transaction by set max_[read|write]_len of i2c_adapter_quirk.
> Large i2c transfer transaction beyond this limitation may fail to complete,
> cause I2C controller driver aborts the transaction and returns failure.
> 
> Therefore this patch was created to split large i2c transaction into
> smaller chunks which can complete within max_[read|write]_len defined
> by I2C controller driver.

Can we consider implementing this chunking logic in i2c core? Otherwise
we will need to adjust pretty much every driver to do this.

Thanks.

-- 
Dmitry

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  9:22 Jiada Wang
2020-07-30  5:54 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730055453.GC1665100@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=Andrew_Gabbasov@mentor.com \
    --cc=digetx@gmail.com \
    --cc=erosca@de.adit-jv.com \
    --cc=jiada_wang@mentor.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@shmanahar.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git