Linux Input Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH 0/3] Modernize tasklet callback API
       [not found] ` <87h7tpa3hg.fsf@nanos.tec.linutronix.de>
@ 2020-07-30 18:14   ` Kees Cook
  2020-08-03  8:46     ` Allen
  0 siblings, 1 reply; 7+ messages in thread
From: Kees Cook @ 2020-07-30 18:14 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: Greg Kroah-Hartman, Allen Pais, Oscar Carter, Romain Perier,
	David S. Miller, Peter Zijlstra, Will Deacon, linux-input,
	linux-kernel, netdev, linux-s390, devel, linux-usb,
	kgdb-bugreport, alsa-devel, kernel-hardening

[heavily trimmed CC list because I think lkml is ignoring this
thread...]

On Thu, Jul 30, 2020 at 09:03:55AM +0200, Thomas Gleixner wrote:
> Kees,
> 
> Kees Cook <keescook@chromium.org> writes:
> > This is the infrastructure changes to prepare the tasklet API for
> > conversion to passing the tasklet struct as the callback argument instead
> > of an arbitrary unsigned long. The first patch details why this is useful
> > (it's the same rationale as the timer_struct changes from a bit ago:
> > less abuse during memory corruption attacks, more in line with existing
> > ways of doing things in the kernel, save a little space in struct,
> > etc). Notably, the existing tasklet API use is much less messy, so there
> > is less to clean up.
> >
> > It's not clear to me which tree this should go through... Greg since it
> > starts with a USB clean-up, -tip for timer or interrupt, or if I should
> > just carry it. I'm open to suggestions, but if I don't hear otherwise,
> > I'll just carry it.
> >
> > My goal is to have this merged for v5.9-rc1 so that during the v5.10
> > development cycle the new API will be available. The entire tree of
> > changes is here[1] currently, but to split it up by maintainer the
> > infrastructure changes need to be landed first.
> >
> > Review and Acks appreciated! :)
> 
> I'd rather see tasklets vanish from the planet completely, but that's
> going to be a daring feat. So, grudgingly:

Understood! I will update the comments near the tasklet API.

> Acked-by: Thomas Gleixner <tglx@linutronix.de>

Thanks!

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Modernize tasklet callback API
  2020-07-30 18:14   ` [PATCH 0/3] Modernize tasklet callback API Kees Cook
@ 2020-08-03  8:46     ` Allen
  2020-08-11 12:16       ` Allen
  2020-08-11 21:33       ` Kees Cook
  0 siblings, 2 replies; 7+ messages in thread
From: Allen @ 2020-08-03  8:46 UTC (permalink / raw)
  To: Kees Cook
  Cc: Thomas Gleixner, Greg Kroah-Hartman, Oscar Carter, Romain Perier,
	David S. Miller, Peter Zijlstra, Will Deacon, linux-input,
	linux-kernel, netdev, linux-s390, devel, linux-usb,
	kgdb-bugreport, alsa-devel, Kernel Hardening

Kees,

>
> [heavily trimmed CC list because I think lkml is ignoring this
> thread...]
>
> On Thu, Jul 30, 2020 at 09:03:55AM +0200, Thomas Gleixner wrote:
> > Kees,
> >
> > Kees Cook <keescook@chromium.org> writes:
> > > This is the infrastructure changes to prepare the tasklet API for
> > > conversion to passing the tasklet struct as the callback argument instead
> > > of an arbitrary unsigned long. The first patch details why this is useful
> > > (it's the same rationale as the timer_struct changes from a bit ago:
> > > less abuse during memory corruption attacks, more in line with existing
> > > ways of doing things in the kernel, save a little space in struct,
> > > etc). Notably, the existing tasklet API use is much less messy, so there
> > > is less to clean up.
> > >
> > > It's not clear to me which tree this should go through... Greg since it
> > > starts with a USB clean-up, -tip for timer or interrupt, or if I should
> > > just carry it. I'm open to suggestions, but if I don't hear otherwise,
> > > I'll just carry it.
> > >
> > > My goal is to have this merged for v5.9-rc1 so that during the v5.10
> > > development cycle the new API will be available. The entire tree of
> > > changes is here[1] currently, but to split it up by maintainer the
> > > infrastructure changes need to be landed first.
> > >
> > > Review and Acks appreciated! :)
> >
> > I'd rather see tasklets vanish from the planet completely, but that's
> > going to be a daring feat. So, grudgingly:
>
> Understood! I will update the comments near the tasklet API.
>
> > Acked-by: Thomas Gleixner <tglx@linutronix.de>
>

Here's the series re-based on top of 5.8
https://github.com/allenpais/tasklets/tree/V3

Let me know how you would want these to be reviewed.

Also, I was thinking if removing tasklets completely could be a task
on KSPP wiki. If yes, I did like to take ownership of that task. I have a
couple of ideas in mind, which could be discussed in a separate email.

Thanks.

-- 
       - Allen

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Modernize tasklet callback API
  2020-08-03  8:46     ` Allen
@ 2020-08-11 12:16       ` Allen
  2020-08-11 21:33       ` Kees Cook
  1 sibling, 0 replies; 7+ messages in thread
From: Allen @ 2020-08-11 12:16 UTC (permalink / raw)
  To: Kees Cook
  Cc: Thomas Gleixner, Greg Kroah-Hartman, Oscar Carter, Romain Perier,
	David S. Miller, Peter Zijlstra, Will Deacon, linux-input,
	linux-kernel, netdev, linux-s390, devel, linux-usb,
	kgdb-bugreport, alsa-devel, Kernel Hardening

Kees,

> >
>
> Here's the series re-based on top of 5.8
> https://github.com/allenpais/tasklets/tree/V3
>
> Let me know how you would want these to be reviewed.
>

  I see the first set of infrastructure patches for tasklets have
landed in Linus's tree. Good time to send out the ~200 patches?

- Allen

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Modernize tasklet callback API
  2020-08-03  8:46     ` Allen
  2020-08-11 12:16       ` Allen
@ 2020-08-11 21:33       ` Kees Cook
  2020-08-12  6:21         ` Takashi Iwai
  2020-08-12 12:31         ` Allen
  1 sibling, 2 replies; 7+ messages in thread
From: Kees Cook @ 2020-08-11 21:33 UTC (permalink / raw)
  To: Allen
  Cc: Thomas Gleixner, Greg Kroah-Hartman, Oscar Carter, Romain Perier,
	David S. Miller, Peter Zijlstra, Will Deacon, linux-input,
	linux-kernel, netdev, linux-s390, devel, linux-usb,
	kgdb-bugreport, alsa-devel, Kernel Hardening

On Mon, Aug 03, 2020 at 02:16:15PM +0530, Allen wrote:
> Here's the series re-based on top of 5.8
> https://github.com/allenpais/tasklets/tree/V3

Great!

> Let me know how you would want these to be reviewed.

Was a Coccinelle script used for any of these conversions? I wonder if
it'd be easier to do a single treewide patch for the more mechanical
changes.

And, actually, I still think the "prepare" patches should just be
collapsed into the actual "covert" patches -- there are only a few.

After those, yeah, I think getting these sent to their respective
maintainers is the next step.

> Also, I was thinking if removing tasklets completely could be a task
> on KSPP wiki. If yes, I did like to take ownership of that task. I have a
> couple of ideas in mind, which could be discussed in a separate email.

Sure! I will add it to the tracker. Here's for the refactoring:
https://github.com/KSPP/linux/issues/30

and here's for the removal:
https://github.com/KSPP/linux/issues/94

if you can added details/examples of how they should be removed, that'd
help other folks too, if they wanted to jump in. :)

-Kees

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Modernize tasklet callback API
  2020-08-11 21:33       ` Kees Cook
@ 2020-08-12  6:21         ` Takashi Iwai
  2020-08-12 11:32           ` Allen
  2020-08-12 12:31         ` Allen
  1 sibling, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2020-08-12  6:21 UTC (permalink / raw)
  To: Kees Cook
  Cc: Allen, devel, linux-s390, alsa-devel, Oscar Carter,
	Kernel Hardening, Peter Zijlstra, Greg Kroah-Hartman, linux-usb,
	linux-kernel, netdev, linux-input, kgdb-bugreport,
	Thomas Gleixner, Romain Perier, Will Deacon, David S. Miller

On Tue, 11 Aug 2020 23:33:13 +0200,
Kees Cook wrote:
> 
> On Mon, Aug 03, 2020 at 02:16:15PM +0530, Allen wrote:
> > Here's the series re-based on top of 5.8
> > https://github.com/allenpais/tasklets/tree/V3
> 
> Great!
> 
> > Let me know how you would want these to be reviewed.
> 
> Was a Coccinelle script used for any of these conversions? I wonder if
> it'd be easier to do a single treewide patch for the more mechanical
> changes.
> 
> And, actually, I still think the "prepare" patches should just be
> collapsed into the actual "covert" patches -- there are only a few.
> 
> After those, yeah, I think getting these sent to their respective
> maintainers is the next step.
> 
> > Also, I was thinking if removing tasklets completely could be a task
> > on KSPP wiki. If yes, I did like to take ownership of that task. I have a
> > couple of ideas in mind, which could be discussed in a separate email.
> 
> Sure! I will add it to the tracker. Here's for the refactoring:
> https://github.com/KSPP/linux/issues/30
> 
> and here's for the removal:
> https://github.com/KSPP/linux/issues/94
> 
> if you can added details/examples of how they should be removed, that'd
> help other folks too, if they wanted to jump in. :)

I have a patch set to convert the remaining tasklet usage in sound
drivers to either the threaded IRQ or the work, but it wasn't
submitted / merged for 5.8 due to the obvious conflict with your API
changes.
Each conversion is rather simple, but it's always a question of the
nature of each tasklet usage which alternative is the best fit.

FWIW, the current version is found in test/kill-tasklet branch of
sound git tree
  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git


thanks,

Takashi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Modernize tasklet callback API
  2020-08-12  6:21         ` Takashi Iwai
@ 2020-08-12 11:32           ` Allen
  0 siblings, 0 replies; 7+ messages in thread
From: Allen @ 2020-08-12 11:32 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Kees Cook, devel, linux-s390, alsa-devel, Oscar Carter,
	Kernel Hardening, Peter Zijlstra, Greg Kroah-Hartman, linux-usb,
	linux-kernel, netdev, linux-input, kgdb-bugreport,
	Thomas Gleixner, Romain Perier, Will Deacon, David S. Miller

>
> I have a patch set to convert the remaining tasklet usage in sound
> drivers to either the threaded IRQ or the work, but it wasn't
> submitted / merged for 5.8 due to the obvious conflict with your API
> changes.
> Each conversion is rather simple, but it's always a question of the
> nature of each tasklet usage which alternative is the best fit.
>
> FWIW, the current version is found in test/kill-tasklet branch of
> sound git tree
>   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

Great. Currently my tree has these converted to use the new
tasklet_setup() api. I will add these to my threaded IRQ/work tree
(which is still wip).

Thanks.


-- 
       - Allen

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Modernize tasklet callback API
  2020-08-11 21:33       ` Kees Cook
  2020-08-12  6:21         ` Takashi Iwai
@ 2020-08-12 12:31         ` Allen
  1 sibling, 0 replies; 7+ messages in thread
From: Allen @ 2020-08-12 12:31 UTC (permalink / raw)
  To: Kees Cook
  Cc: Thomas Gleixner, Greg Kroah-Hartman, Oscar Carter, Romain Perier,
	David S. Miller, Peter Zijlstra, Will Deacon, linux-input,
	linux-kernel, netdev, linux-s390, devel, linux-usb,
	kgdb-bugreport, alsa-devel, Kernel Hardening

Kees,

> Was a Coccinelle script used for any of these conversions? I wonder if
> it'd be easier to do a single treewide patch for the more mechanical
> changes.

No, I should have written one. Will do it.

> And, actually, I still think the "prepare" patches should just be
> collapsed into the actual "covert" patches -- there are only a few.

Okay. It's been done and pushed to:
https://github.com/allenpais/tasklets/tree/V4

> After those, yeah, I think getting these sent to their respective
> maintainers is the next step.

 Please look at the above branch, if it looks fine, let me know
if I can add your ACK on the patches.
>
> Sure! I will add it to the tracker. Here's for the refactoring:
> https://github.com/KSPP/linux/issues/30
>
> and here's for the removal:
> https://github.com/KSPP/linux/issues/94
>
> if you can added details/examples of how they should be removed, that'd
> help other folks too, if they wanted to jump in. :)

Sure, Thank you.

- Allen

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200716030847.1564131-1-keescook@chromium.org>
     [not found] ` <87h7tpa3hg.fsf@nanos.tec.linutronix.de>
2020-07-30 18:14   ` [PATCH 0/3] Modernize tasklet callback API Kees Cook
2020-08-03  8:46     ` Allen
2020-08-11 12:16       ` Allen
2020-08-11 21:33       ` Kees Cook
2020-08-12  6:21         ` Takashi Iwai
2020-08-12 11:32           ` Allen
2020-08-12 12:31         ` Allen

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git