From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4029C433DF for ; Wed, 19 Aug 2020 12:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 970CB2075E for ; Wed, 19 Aug 2020 12:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597838984; bh=ds1bI2FNOetemI0iGOxjd//vmJ7FuX5vgPU2SVW5nOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Xylfp1gSWjPpX66SE37T2mNBEyM9LV1bGvVPzm+KCOv3trPNF3M7NOLQl9NTjoqcu B4cHisrmVr5qT9Tpr0VcNPAeY6JnE6S1BJ7xiXlMjUTn8J4GltifJoQJ3DBloQUrRY sblck15eflV/4qNQ2RpdaP443DVtS13jX4SIp58U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727018AbgHSMJj (ORCPT ); Wed, 19 Aug 2020 08:09:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:46818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728200AbgHSMIe (ORCPT ); Wed, 19 Aug 2020 08:08:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9E36205CB; Wed, 19 Aug 2020 12:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597838914; bh=ds1bI2FNOetemI0iGOxjd//vmJ7FuX5vgPU2SVW5nOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p/C6dXOhGr5YrrBD8slToXpFiWvIHbiPDOvXWigza0lxxRXRnLPlwHZI9paHkeb1N M4gl2HAbv84kIqey4gd+t1DIqIUOzNWzBwTs+HjZfQOz2ZzOHlBj8j0wQzyRs7DuNg Werlhf12WnCxzoLwZubGDmLmSuSP0vTLPYlyy/EY= Date: Wed, 19 Aug 2020 14:08:56 +0200 From: Greg KH To: penghao Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB HID: Add disabled wakeup from s3 by touchpad on byd zhaoxin notebook Message-ID: <20200819120856.GA931936@kroah.com> References: <20200819115101.22532-1-penghao@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819115101.22532-1-penghao@uniontech.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Aug 19, 2020 at 07:51:01PM +0800, penghao wrote: > BYD Notebook built-in touch pad, USB interface,so disabled,the touch pad > device idVendor 0x0c45 idProduct 0x7056 > > Signed-off-by: penghao > --- > drivers/hid/usbhid/hid-core.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c > index 492dd641a25d..630a3cad211f 100644 > --- a/drivers/hid/usbhid/hid-core.c > +++ b/drivers/hid/usbhid/hid-core.c > @@ -1193,7 +1193,13 @@ static int usbhid_start(struct hid_device *hid) > interface->desc.bInterfaceProtocol == > USB_INTERFACE_PROTOCOL_KEYBOARD) { > usbhid_set_leds(hid); > - device_set_wakeup_enable(&dev->dev, 1); > + /* > + * USB HID: Add disabled touchpad wakeup on byd zhaoxin notebook > + */ > + if ((hid->vendor == 0x0c45) && (hid->product == 0x7056)) > + device_set_wakeup_enable(&dev->dev, 0); > + else > + device_set_wakeup_enable(&dev->dev, 1); Shouldn't this be a quirk somewhere instead of this core check? thanks, greg k-h