From: Frank Yang <puilp0502@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] HID: Support Varmilo Keyboards' media hotkeys
Date: Fri, 21 Aug 2020 03:23:01 +0900 [thread overview]
Message-ID: <20200820182301.GA23223@frank-MS-7C02> (raw)
In-Reply-To: <nycvar.YFH.7.76.2008171202130.27422@cbobk.fhfr.pm>
On Mon, Aug 17, 2020 at 12:03:26PM +0200, Jiri Kosina wrote:
> On Wed, 29 Jul 2020, Frank Yang wrote:
>
> > The Varmilo VA104M Keyboard (04b4:07b1, reported as Varmilo Z104M)
> > exposes media control hotkeys as a USB HID consumer control device,
> > but these keys do not work in the current (5.8-rc1) kernel due to
> > the incorrect HID report descriptor. Fix the problem by modifying
> > the internal HID report descriptor.
> >
> > More specifically, the keyboard report descriptor specifies the
> > logical boundary as 572~10754 (0x023c ~ 0x2a02) while the usage
> > boundary is specified as 0~10754 (0x00 ~ 0x2a02). This results in an
> > incorrect interpretation of input reports, causing inputs to be ignored.
> > By setting the Logical Minimum to zero, we align the logical boundary
> > with the Usage ID boundary.
> >
> > Some notes:
> >
> > * There seem to be multiple variants of the VA104M keyboard. This
> > patch specifically targets 04b4:07b1 variant.
> >
> > * The device works out-of-the-box on Windows platform with the generic
> > consumer control device driver (hidserv.inf). This suggests that
> > Windows either ignores the Logical Minimum/Logical Maximum or
> > interprets the Usage ID assignment differently from the linux
> > implementation; Maybe there are other devices out there that only
> > works on Windows due to this problem?
> >
> > Signed-off-by: Frank Yang <puilp0502@gmail.com>
> > ---
> > drivers/hid/Kconfig | 6 ++++
> > drivers/hid/Makefile | 1 +
> > drivers/hid/hid-ids.h | 2 ++
> > drivers/hid/hid-varmilo.c | 58 +++++++++++++++++++++++++++++++++++++++
>
> Hi Frank,
>
> thanks for the patch.
>
> Given the fact that the device presents itself with CYPRESS VID (0x04b4,
> 'officially' assigned to cypress), can we avoid creating extra driver, and
> rather extend hid-cypress.c with this quirk, please?
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
Hi Jiri,
thanks for your comment.
As you stated, I have sent the updated patch which extends hid-cypress.c
instead of creating new driver.
Thanks,
Frank
next prev parent reply other threads:[~2020-08-20 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 13:53 [PATCH] HID: Support Varmilo Keyboards' media hotkeys Frank Yang
2020-08-17 10:03 ` Jiri Kosina
2020-08-20 18:23 ` Frank Yang [this message]
2020-08-20 18:16 ` [PATCH v2] " Frank Yang
2020-10-23 11:25 ` Jiri Kosina
[not found] <20200720200916.31082-1-puilp0502@gmail.com>
2020-07-20 20:24 ` [PATCH] " Frank Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820182301.GA23223@frank-MS-7C02 \
--to=puilp0502@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).