From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 274A2C433DF for ; Thu, 27 Aug 2020 18:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BB252073A for ; Thu, 27 Aug 2020 18:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598553644; bh=dt4coWxXNYjS65WOHU4f6EglIm6iQ5oF+Hm9UigsEGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=G2n7NrljSUxgYxciDxkms8RCop9xvX+nth/DYy8tzxBnRliRkQuguNW/tyLyXEf4e CMHGYpzULQx6JQIgGtfSnL0uMeC2mbM05gvup2jPWNzW/P3oiI4kzLHX0AaCtLX5iL nrdw5pH4z/PJxAx/cr2cUqxMaqMwkkK20XiNqzcA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726147AbgH0Skm (ORCPT ); Thu, 27 Aug 2020 14:40:42 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:44793 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbgH0Skj (ORCPT ); Thu, 27 Aug 2020 14:40:39 -0400 Received: by mail-ej1-f67.google.com with SMTP id bo3so8996454ejb.11; Thu, 27 Aug 2020 11:40:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oDVzVcv1GncA1A9GcBvmV28MulHRr/qR43lfCwrJOTA=; b=M6z8y26Nrts5BQkTq1yXho7eO88kxt2CmOnsnGfCnXW5zJ7dVDwUQxoa7h8Bq1VgH4 QW/vIgWiR5yWlElzh1IJsS+dnnHm4RKn6EnmGHeBSfIk5m4tAAG2k1sb8b+HcjERXdc0 CQN1Y7x/spgc5YW39lGWPYKxJ/fx3dp6NXBZcsmmMQlD3Kkm7CptSoqScYbYNDnx7bAP sDBPjAq3zhNFnpYml29u1XGc8cm3GUnXV0sG8aaYePJmB/n+G+1Mx2eKCDpj3GM+JKGg cIEUmfK0hBPE21Sit7lx7VkNHeMUQmJCx2BIzb6TwD/82xjnwle8YWo3PkmdtADRZEoK hLvA== X-Gm-Message-State: AOAM531YZJdbcnOvKefqKv8iCxAYDqKcbq1Q4CTEc/Qvp88u2skOeyan Ngan8bIW5N8iilqQ+KZ3ToqSx8i8WZvkwQfD X-Google-Smtp-Source: ABdhPJzQQrQizKXpDDhYdOaCPsxpZIWrNGdEeJeRidRKKnvdNVG6McNFLXQexn76rx0LV0wDSyWK6A== X-Received: by 2002:a17:906:1351:: with SMTP id x17mr21236951ejb.528.1598553636707; Thu, 27 Aug 2020 11:40:36 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id m4sm2609458ejn.31.2020.08.27.11.40.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Aug 2020 11:40:36 -0700 (PDT) Date: Thu, 27 Aug 2020 20:40:33 +0200 From: Krzysztof Kozlowski To: Andy Shevchenko Cc: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , "Gustavo A. R. Silva" , Andy Shevchenko , linux-input , Linux Kernel Mailing List , Platform Driver Subject: Re: [PATCH 04/24] Input: gpio-vibra - Simplify with dev_err_probe() Message-ID: <20200827184033.GA6196@kozik-lap> References: <20200826181706.11098-1-krzk@kernel.org> <20200826181706.11098-4-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Aug 27, 2020 at 12:03:52PM +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 9:20 PM Krzysztof Kozlowski wrote: > > > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > vibrator->vcc = devm_regulator_get(&pdev->dev, "vcc"); > > err = PTR_ERR_OR_ZERO(vibrator->vcc); > > - if (err) { > > - if (err != -EPROBE_DEFER) > > - dev_err(&pdev->dev, "Failed to request regulator: %d\n", > > - err); > > - return err; > > - } > > + if (err) > > + return dev_err_probe(&pdev->dev, err, "Failed to request regulator\n"); > > Can it be rather > if (IS_ERR()) > return dev_err_probe(dev, PTR_ERR()); > w/o err be involved? Good point. Best regards, Krzysztof