From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Hans de Goede <hdegoede@redhat.com>,
Bastien Nocera <hadess@hadess.net>,
Sangwon Jee <jeesw@melfas.com>,
Eugen Hristev <eugen.hristev@microchip.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v3 01/27] Input: Simplify with dev_err_probe()
Date: Fri, 2 Oct 2020 18:23:53 +0200 [thread overview]
Message-ID: <20201002162353.GA5870@kozik-lap> (raw)
In-Reply-To: <20200827185829.30096-1-krzk@kernel.org>
On Thu, Aug 27, 2020 at 08:58:02PM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v2:
> 1. Add review tags,
> 2. Fixes after review (see individual patches).
> 3. Two new patches - 26 and 27.
>
>
Hi Dmitry,
Any comments here? Some of these nicely simplify the code or remove some
lines.
Best regards,
Krzysztof
> Best regards,
> Krzysztof
>
>
>
> Krzysztof Kozlowski (27):
> Input: gpio_keys_polled - Simplify with dev_err_probe()
> Input: gpio-vibra - Simplify with dev_err_probe()
> Input: pwm-beeper - Simplify with dev_err_probe()
> Input: pwm-vibra - Simplify with dev_err_probe()
> Input: rotary_encoder - Simplify with dev_err_probe()
> Input: elan_i2c - Simplify with dev_err_probe()
> Input: bu21013_ts - Simplify with dev_err_probe()
> Input: bu21029_ts - Simplify with dev_err_probe()
> Input: chipone_icn8318 - Simplify with dev_err_probe()
> Input: cy8ctma140 - Simplify with dev_err_probe()
> Input: edf-ft5x06 - Simplify with dev_err_probe()
> Input: ektf2127 - Simplify with dev_err_probe()
> Input: elants_i2c - Simplify with dev_err_probe()
> Input: goodix - Simplify with dev_err_probe()
> Input: melfas_mip4 - Simplify with dev_err_probe()
> Input: pixcir_i2c_ts - Simplify with dev_err_probe()
> Input: raydium_i2c_ts - Simplify with dev_err_probe()
> Input: resistive-adc-touch - Simplify with dev_err_probe()
> Input: silead - Simplify with dev_err_probe()
> Input: sis_i2c - Simplify with dev_err_probe()
> Input: surface3_spi - Simplify with dev_err_probe()
> Input: sx8643 - Simplify with dev_err_probe()
> Input: bcm-keypad - Simplify with dev_err_probe()
> gpio: Add devm_fwnode_gpiod_get_optional() helpers
> Input: gpio_keys - Simplify with dev_err_probe()
> Input: bu21013_ts - Use local 'client->dev' variable in probe()
> Input: bu21029_ts - Use local 'client->dev' variable in probe()
>
> drivers/gpio/gpiolib-devres.c | 71 ++++++++++++++++++
> drivers/input/keyboard/bcm-keypad.c | 14 ++--
> drivers/input/keyboard/gpio_keys.c | 25 +++----
> drivers/input/keyboard/gpio_keys_polled.c | 8 +--
> drivers/input/misc/gpio-vibra.c | 20 ++----
> drivers/input/misc/pwm-beeper.c | 19 ++---
> drivers/input/misc/pwm-vibra.c | 20 ++----
> drivers/input/misc/rotary_encoder.c | 8 +--
> drivers/input/mouse/elan_i2c_core.c | 9 +--
> drivers/input/touchscreen/bu21013_ts.c | 72 ++++++++-----------
> drivers/input/touchscreen/bu21029_ts.c | 53 ++++++--------
> drivers/input/touchscreen/chipone_icn8318.c | 8 +--
> drivers/input/touchscreen/cy8ctma140.c | 8 +--
> drivers/input/touchscreen/edt-ft5x06.c | 10 +--
> drivers/input/touchscreen/ektf2127.c | 8 +--
> drivers/input/touchscreen/elants_i2c.c | 22 ++----
> drivers/input/touchscreen/goodix.c | 40 +++--------
> drivers/input/touchscreen/melfas_mip4.c | 9 +--
> drivers/input/touchscreen/pixcir_i2c_ts.c | 38 ++++------
> drivers/input/touchscreen/raydium_i2c_ts.c | 30 +++-----
> .../input/touchscreen/resistive-adc-touch.c | 8 +--
> drivers/input/touchscreen/silead.c | 8 +--
> drivers/input/touchscreen/sis_i2c.c | 20 ++----
> drivers/input/touchscreen/surface3_spi.c | 13 +---
> drivers/input/touchscreen/sx8654.c | 10 +--
> include/linux/gpio/consumer.h | 30 ++++++++
> 26 files changed, 253 insertions(+), 328 deletions(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-10-02 16:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 18:58 [PATCH v3 01/27] Input: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 01/27] Input: gpio_keys_polled - " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 02/27] Input: gpio-vibra " Krzysztof Kozlowski
2020-08-27 19:36 ` Andy Shevchenko
2020-08-27 18:58 ` [PATCH v3 03/27] Input: pwm-beeper " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 04/27] Input: pwm-vibra " Krzysztof Kozlowski
2020-08-27 19:39 ` Andy Shevchenko
2020-08-27 18:58 ` [PATCH v3 05/27] Input: rotary_encoder " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 06/27] Input: elan_i2c " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 07/27] Input: bu21013_ts " Krzysztof Kozlowski
2020-08-27 19:39 ` Andy Shevchenko
2020-08-28 14:29 ` Linus Walleij
2020-08-27 18:58 ` [PATCH v3 08/27] Input: bu21029_ts " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 09/27] Input: chipone_icn8318 " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 10/27] Input: cy8ctma140 " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 11/27] Input: edf-ft5x06 " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 12/27] Input: ektf2127 " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 13/27] Input: elants_i2c " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 14/27] Input: goodix " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 15/27] Input: melfas_mip4 " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 16/27] Input: pixcir_i2c_ts " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 17/27] Input: raydium_i2c_ts " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 18/27] Input: resistive-adc-touch " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 19/27] Input: silead " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 20/27] Input: sis_i2c " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 21/27] Input: surface3_spi " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 22/27] Input: sx8643 " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 23/27] Input: bcm-keypad " Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 24/27] gpio: Add devm_fwnode_gpiod_get_optional() helpers Krzysztof Kozlowski
2020-08-28 14:31 ` Linus Walleij
2020-08-28 14:45 ` Krzysztof Kozlowski
2020-08-28 14:56 ` Andy Shevchenko
2020-08-27 18:58 ` [PATCH v3 25/27] Input: gpio_keys - Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-27 18:58 ` [PATCH v3 26/27] Input: bu21013_ts - Use local 'client->dev' variable in probe() Krzysztof Kozlowski
2020-08-27 19:43 ` Andy Shevchenko
2020-08-27 19:47 ` [PATCH v3.1] " Krzysztof Kozlowski
2020-08-28 14:32 ` [PATCH v3 26/27] " Linus Walleij
2020-08-27 18:58 ` [PATCH v3 27/27] Input: bu21029_ts " Krzysztof Kozlowski
2020-08-27 19:44 ` Andy Shevchenko
2020-10-02 16:23 ` Krzysztof Kozlowski [this message]
2021-09-16 19:40 ` [PATCH v3 01/27] Input: Simplify with dev_err_probe() Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002162353.GA5870@kozik-lap \
--to=krzk@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eugen.hristev@microchip.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=jeesw@melfas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).