From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: accel: bmc150-accel: Add DT bindings
Date: Sun, 1 Nov 2020 20:44:56 +0000 [thread overview]
Message-ID: <20201101204456.2f15616a@archlinux> (raw)
In-Reply-To: <20201101122833.1111424-1-linus.walleij@linaro.org>
On Sun, 1 Nov 2020 13:28:31 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> These accelerometers have bindings used in the kernel and
> several device trees but no proper bindings documentation.
> Add it.
>
> Also add a compatible for the BMA222 that I am right now
> adding support for in the driver.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Hi Linus,
A few minor things inline.
Great to be plugging some of the holes in binding docs.
Doing a complete check is on my todo list :)
Jonathan
> ---
> .../bindings/iio/accel/bosch,bmc-bmi-bma.yaml | 72 +++++++++++++++++++
So far we only have a few bindings that aren't named after a supported part.
Give we have other devices that match these letters, I don't think we want to
do it here. Just confused people!
Pick a part and name it after that.
> 1 file changed, 72 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmc-bmi-bma.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmc-bmi-bma.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmc-bmi-bma.yaml
> new file mode 100644
> index 000000000000..11b8b68aaf3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmc-bmi-bma.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/bosch,bmc-bmi-bma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bosch BMCxxx, BMIxxx and BMAxxx Accelerometers
Some of them... see bma180.txt in the same directory.
I'd go with bma255 and similar (chose your favourite part number)
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@linaro.org>
> +
> +description:
> + 3 axis accelerometers with varying range and I2C or SPI
> + 3-wire interface.
Looks like 4-wire to me. CSB, SPI-CLK, SDO, SDI.
> +
> +properties:
> + compatible:
> + enum:
> + - bosch,bmc150
> + - bosch,bmi055
> + - bosch,bma255
> + - bosch,bma250e
> + - bosch,bma222
> + - bosch,bma222e
> + - bosch,bma280
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply: true
> + vddio-supply: true
> +
> + interrupts:
> + maxItems: 1
> +
> + mount-matrix:
> + description: an optional 3x3 mounting rotation matrix.
> +
> + spi-max-frequency: true
Don't suppose these all share a common max?
I looked at a few and 10MHz was the value for those.
Always nice to pin things down a bit if we can!
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #address-cells = <1>;
> + #size-cells = <0>;
> + accelerometer@8 {
> + compatible = "bosch,bma222";
> + reg = <0x08>;
> + vddio-supply = <&vddio>;
> + vdd-supply = <&vdd>;
> + interrupts = <57 IRQ_TYPE_EDGE_FALLING>;
> + };
> + };
> + - |
> + # include <dt-bindings/interrupt-controller/irq.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + accel@0 {
> + compatible = "bosch,bma222";
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + };
> + };
> +...
prev parent reply other threads:[~2020-11-01 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 12:28 [PATCH 1/3] iio: accel: bmc150-accel: Add DT bindings Linus Walleij
2020-11-01 12:28 ` [PATCH 2/3] iio: accel: bmc150-accel: Add support for BMA222 Linus Walleij
2020-11-01 20:47 ` Jonathan Cameron
2020-11-01 12:28 ` [PATCH 3/3] iio: accel: bmc150-accel: Add rudimentary regulator support Linus Walleij
2020-11-01 20:52 ` Jonathan Cameron
2020-11-01 20:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101204456.2f15616a@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).