* [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC
@ 2020-11-02 22:15 Necip Fazil Yildiran
2020-11-03 10:58 ` Jonathan Cameron
2020-11-12 1:49 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Necip Fazil Yildiran @ 2020-11-02 22:15 UTC (permalink / raw)
To: dmitry.torokhov
Cc: Jonathan.Cameron, eugen.hristev, linux-input, linux-kernel, paul,
jeho, Necip Fazil Yildiran
When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
in the following Kbuild warning:
WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
Selected by [y]:
- TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]
The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
can also fail building the kernel.
Honor the kconfig dependency to remove unmet direct dependency warnings
and avoid any potential build failures.
Fixes: aa132ffb6b0a ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=209881
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
drivers/input/touchscreen/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index f012fe746df0..cc18f54ea887 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -96,6 +96,7 @@ config TOUCHSCREEN_AD7879_SPI
config TOUCHSCREEN_ADC
tristate "Generic ADC based resistive touchscreen"
depends on IIO
+ select IIO_BUFFER
select IIO_BUFFER_CB
help
Say Y here if you want to use the generic ADC
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC
2020-11-02 22:15 [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC Necip Fazil Yildiran
@ 2020-11-03 10:58 ` Jonathan Cameron
2020-11-12 1:49 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-11-03 10:58 UTC (permalink / raw)
To: Necip Fazil Yildiran
Cc: dmitry.torokhov, eugen.hristev, linux-input, linux-kernel, paul, jeho
On Tue, 3 Nov 2020 01:15:05 +0300
Necip Fazil Yildiran <fazilyildiran@gmail.com> wrote:
> When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]
>
> The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
> on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
> can also fail building the kernel.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Fixes: aa132ffb6b0a ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209881
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index f012fe746df0..cc18f54ea887 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -96,6 +96,7 @@ config TOUCHSCREEN_AD7879_SPI
> config TOUCHSCREEN_ADC
> tristate "Generic ADC based resistive touchscreen"
> depends on IIO
> + select IIO_BUFFER
> select IIO_BUFFER_CB
> help
> Say Y here if you want to use the generic ADC
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC
2020-11-02 22:15 [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC Necip Fazil Yildiran
2020-11-03 10:58 ` Jonathan Cameron
@ 2020-11-12 1:49 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2020-11-12 1:49 UTC (permalink / raw)
To: Necip Fazil Yildiran
Cc: Jonathan.Cameron, eugen.hristev, linux-input, linux-kernel, paul, jeho
On Tue, Nov 03, 2020 at 01:15:05AM +0300, Necip Fazil Yildiran wrote:
> When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]
>
> The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
> on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
> can also fail building the kernel.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Fixes: aa132ffb6b0a ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209881
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-12 5:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 22:15 [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC Necip Fazil Yildiran
2020-11-03 10:58 ` Jonathan Cameron
2020-11-12 1:49 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).