From: Rob Herring <robh@kernel.org>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Orson Zhai <orsonzhai@gmail.com>,
linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
devicetree@vger.kernel.org, Baolin Wang <baolin.wang7@gmail.com>,
Nemo Han <nemo.han@unisoc.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: input: Convert sc27xx-vibra.txt to json-schema
Date: Mon, 16 Nov 2020 08:54:44 -0600 [thread overview]
Message-ID: <20201116145444.GA1635499@bogus> (raw)
In-Reply-To: <20201113113451.52355-2-zhang.lyra@gmail.com>
On Fri, 13 Nov 2020 19:34:50 +0800, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
>
> Convert the sprd sc27xx vibrator binding to DT schema using json-schema.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
> .../bindings/input/sprd,sc27xx-vibra.txt | 23 ----------
> .../bindings/input/sprd,sc27xx-vibrator.yaml | 44 +++++++++++++++++++
> 2 files changed, 44 insertions(+), 23 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/sprd,sc27xx-vibra.txt
> create mode 100644 Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml: 'additionalProperties' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
See https://patchwork.ozlabs.org/patch/1399724
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-16 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:34 [PATCH 1/3] input: sc27xx: Add support for sc2730 and sc2721 Chunyan Zhang
2020-11-13 11:34 ` [PATCH 2/3] dt-bindings: input: Convert sc27xx-vibra.txt to json-schema Chunyan Zhang
2020-11-16 14:54 ` Rob Herring [this message]
2020-11-17 3:34 ` Chunyan Zhang
2020-11-13 11:34 ` [PATCH 3/3] dt-bindings: input: Add compatible string for SC2721 and SC2730 Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116145444.GA1635499@bogus \
--to=robh@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nemo.han@unisoc.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).