* [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet
@ 2020-11-17 0:42 Simon Beginn
2020-11-17 15:05 ` Bastien Nocera
0 siblings, 1 reply; 5+ messages in thread
From: Simon Beginn @ 2020-11-17 0:42 UTC (permalink / raw)
To: linux-input
The touchscreen on the Teclast x98 Pro is also mounted upside-down in relation to the display orientation. I added it also to the list of those devices. Verified it works on my device - this has not been tested with more users than myself...
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index f8dd416c89b2..7668174b62ed 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -136,6 +136,16 @@ static const struct dmi_system_id rotated_screen[] = {
DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
},
},
+ {
+ .ident = "Teclast X98 Pro",
+ .matches = {
+ /* Only match bios date, because the manufacturers bios
+ * does not report the board name at all (sometimes)...
+ */
+ DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
+ DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"),
+ },
+ },
{
.ident = "WinBook TW100",
.matches = {
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet
2020-11-17 0:42 [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet Simon Beginn
@ 2020-11-17 15:05 ` Bastien Nocera
2020-12-07 15:13 ` Bastien Nocera
[not found] ` <434f5579-5ca7-5f54-c853-af720769e1cc@simonmicro.de>
0 siblings, 2 replies; 5+ messages in thread
From: Bastien Nocera @ 2020-11-17 15:05 UTC (permalink / raw)
To: linux, linux-input
On Mon, 2020-11-16 at 19:42 -0500, Simon Beginn wrote:
> The touchscreen on the Teclast x98 Pro is also mounted upside-down in
> relation to the display orientation. I added it also to the list of
> those devices. Verified it works on my device - this has not been
> tested with more users than myself...
Looks good to me, thanks.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
>
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index f8dd416c89b2..7668174b62ed 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -136,6 +136,16 @@ static const struct dmi_system_id
> rotated_screen[] = {
> DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
> },
> },
> + {
> + .ident = "Teclast X98 Pro",
> + .matches = {
> + /* Only match bios date, because the
> manufacturers bios
> + * does not report the board name at all
> (sometimes)...
> + */
> + DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
> + DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"),
> + },
> + },
> {
> .ident = "WinBook TW100",
> .matches = {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet
2020-11-17 15:05 ` Bastien Nocera
@ 2020-12-07 15:13 ` Bastien Nocera
2020-12-08 1:53 ` Dmitry Torokhov
[not found] ` <434f5579-5ca7-5f54-c853-af720769e1cc@simonmicro.de>
1 sibling, 1 reply; 5+ messages in thread
From: Bastien Nocera @ 2020-12-07 15:13 UTC (permalink / raw)
To: linux, linux-input; +Cc: Dmitry Torokhov
On Tue, 2020-11-17 at 16:05 +0100, Bastien Nocera wrote:
> On Mon, 2020-11-16 at 19:42 -0500, Simon Beginn wrote:
> > The touchscreen on the Teclast x98 Pro is also mounted upside-down
> > in
> > relation to the display orientation. I added it also to the list of
> > those devices. Verified it works on my device - this has not been
> > tested with more users than myself...
>
> Looks good to me, thanks.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
Dmitry, this seems to have slipped through the cracks. Can you please
pick it up for the next merge window?
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet
2020-12-07 15:13 ` Bastien Nocera
@ 2020-12-08 1:53 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2020-12-08 1:53 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux, linux-input
Hi Bastien,
On Mon, Dec 07, 2020 at 04:13:06PM +0100, Bastien Nocera wrote:
> On Tue, 2020-11-17 at 16:05 +0100, Bastien Nocera wrote:
> > On Mon, 2020-11-16 at 19:42 -0500, Simon Beginn wrote:
> > > The touchscreen on the Teclast x98 Pro is also mounted upside-down
> > > in
> > > relation to the display orientation. I added it also to the list of
> > > those devices. Verified it works on my device - this has not been
> > > tested with more users than myself...
> >
> > Looks good to me, thanks.
> >
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
>
> Dmitry, this seems to have slipped through the cracks. Can you please
> pick it up for the next merge window?
Argh, the original patch went into spam folder because the domain
requires dmarc enforcement and Gmail is happy to oblige:
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-input-owner@vger.kernel.org
designates 23.128.96.18 as permitted sender)
smtp.mailfrom=linux-input-owner@vger.kernel.org;
dmarc=fail (p=REJECT sp=REJECT dis=QUARANTINE)
header.from=simonmicro.de
Regardless, I need "Signed-off-by" from Simon before I can apply it.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <434f5579-5ca7-5f54-c853-af720769e1cc@simonmicro.de>]
end of thread, other threads:[~2020-12-11 23:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 0:42 [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet Simon Beginn
2020-11-17 15:05 ` Bastien Nocera
2020-12-07 15:13 ` Bastien Nocera
2020-12-08 1:53 ` Dmitry Torokhov
[not found] ` <434f5579-5ca7-5f54-c853-af720769e1cc@simonmicro.de>
[not found] ` <5f9a868c166e13062a2109ab868f9e806aafc563.camel@hadess.net>
[not found] ` <111d63473070310b1576c633e4e5debac0a4b22f.camel@hadess.net>
[not found] ` <422df127-449f-247f-bb7e-005575dc23cd@simonmicro.de>
2020-12-11 22:36 ` Fwd: " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).