From: Coiby Xu <coiby.xu@gmail.com>
To: "Barnabás Pőcze" <pobrn@protonmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Helmut Stult <helmut.stult@schinfo.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status
Date: Mon, 23 Nov 2020 22:36:13 +0800 [thread overview]
Message-ID: <20201123143613.zzrm3wgm4m6ngvrz@Rk> (raw)
In-Reply-To: <xsbDy_74QEfC8byvpA0nIjI0onndA3wuiLm2Iattq-8TLPy28kMq7GKhkfrfzqdBAQfp_w5CTCCJ8XjFmegtZqP58xioheh7OHV7Bam33aQ=@protonmail.com>
On Sun, Nov 22, 2020 at 01:33:01PM +0000, Barnabás Pőcze wrote:
>Hi
>
>
>2020. november 22., vasárnap 11:15 keltezéssel, Coiby Xu írta:
>
>> [...]
>> >> +static int get_gpio_pin_state(struct irq_desc *irq_desc)
>> >> +{
>> >> + struct gpio_chip *gc = irq_data_get_irq_chip_data(&irq_desc->irq_data);
>> >> +
>> >> + return gc->get(gc, irq_desc->irq_data.hwirq);
>> >> +}
>> [...]
>> >> + ssize_t status = get_gpio_pin_state(irq_desc);
>> >
>> >`get_gpio_pin_state()` returns an `int`, so I am not sure why `ssize_t` is used here.
>> >
>>
>> I used `ssize_t` because I found gpiolib-sysfs.c uses `ssize_t`
>>
>> // drivers/gpio/gpiolib-sysfs.c
>> static ssize_t value_show(struct device *dev,
>> struct device_attribute *attr, char *buf)
>> {
>> struct gpiod_data *data = dev_get_drvdata(dev);
>> struct gpio_desc *desc = data->desc;
>> ssize_t status;
>>
>> mutex_lock(&data->mutex);
>>
>> status = gpiod_get_value_cansleep(desc);
>> ...
>> return status;
>> }
>>
>> According to the book Advanced Programming in the UNIX Environment by
>> W. Richard Stevens,
>> With the 1990 POSIX.1 standard, the primitive system data type
>> ssize_t was introduced to provide the signed return value...
>>
>> So ssize_t is fairly common, for example, the read and write syscall
>> return a value of type ssize_t. But I haven't found out why ssize_t is
>> better int.
>> >
>
>Sorry if I wasn't clear, what prompted me to ask that question is the following:
>`gc->get()` returns `int`, `get_gpio_pin_state()` returns `int`, yet you still
>save the return value of `get_gpio_pin_state()` into a variable with type
>`ssize_t` for no apparent reason. In the example you cited, `ssize_t` is used
>because the show() callback of a sysfs attribute must return `ssize_t`, but here,
>`interrupt_line_active()` returns `bool`, so I don't see any advantage over a
>plain `int`. Anyways, I believe either one is fine, I just found it odd.
>
I don't understand why "the show() callback of a sysfs attribute
must return `ssize_t`" instead of int. Do you think the rationale
behind it is the same for this case? If yes, using "ssize_t" for
status could be justified.
>
>> >> +
>> >> + if (status < 0) {
>> >> + dev_warn(&client->dev,
>> >> + "Failed to get GPIO Interrupt line status for %s",
>> >> + client->name);
>> >
>> >I think it's possible that the kernel message buffer is flooded with these
>> >messages, which is not optimal in my opinion.
>> >
>> Thank you! Replaced with dev_dbg in v4.
>> [...]
>
>Have you looked at `dev_{warn,dbg,...}_ratelimited()`?
>
Thank you for pointing me to these functions!
>
>Regards,
>Barnabás Pőcze
--
Best regards,
Coiby
next prev parent reply other threads:[~2020-11-23 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 13:49 [PATCH v3] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status Coiby Xu
2020-10-22 14:22 ` Barnabás Pőcze
2020-11-22 10:15 ` Coiby Xu
2020-11-22 13:33 ` Barnabás Pőcze
2020-11-23 14:36 ` Coiby Xu [this message]
2020-11-23 16:32 ` Barnabás Pőcze
2020-11-25 10:57 ` Coiby Xu
2020-11-25 12:39 ` Barnabás Pőcze
2020-11-25 13:18 ` Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123143613.zzrm3wgm4m6ngvrz@Rk \
--to=coiby.xu@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=helmut.stult@schinfo.de \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).