Linux Input Archive on
 help / color / Atom feed
From: Randy Dunlap <>
Cc: Randy Dunlap <>,
	kernel test robot <>,
	Hans de Goede <>,
	Dmitry Torokhov <>,
Subject: [PATCH] input: soc_button_array: fix IRQ-related build errors
Date: Mon, 23 Nov 2020 16:18:02 -0800
Message-ID: <> (raw)

Fix these new build errors by adding <linux/irq.h>:

../drivers/input/misc/soc_button_array.c: In function ‘soc_button_device_create’:
../drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function ‘irq_set_irq_type’; did you mean ‘acpi_dev_get_irq_type’? [-Werror=implicit-function-declaration]
    irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
  CC [M]  drivers/rtc/rtc-ds1343.o
../drivers/input/misc/soc_button_array.c:156:26: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function)
    irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);

Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags")
Signed-off-by: Randy Dunlap <>
Reported-by: kernel test robot <>
Cc: Hans de Goede <>
Cc: Dmitry Torokhov <>
 drivers/input/misc/soc_button_array.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20201123.orig/drivers/input/misc/soc_button_array.c
+++ linux-next-20201123/drivers/input/misc/soc_button_array.c
@@ -9,6 +9,7 @@
 #include <linux/module.h>
 #include <linux/input.h>
 #include <linux/init.h>
+#include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/acpi.h>
 #include <linux/dmi.h>

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24  0:18 Randy Dunlap [this message]
2020-11-24  9:39 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on

Archives are clonable:
	git clone --mirror linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ \
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone