linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com, x86@kernel.org, hpa@zytor.com,
	dmitry.torokhov@gmail.com, derek.kiernan@xilinx.com,
	dragan.cvetic@xilinx.com, richardcochran@gmail.com,
	linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] x86: make VMware support optional
Date: Thu, 3 Dec 2020 08:46:59 +0100	[thread overview]
Message-ID: <20201203074631.GC3059@zn.tnic> (raw)
In-Reply-To: <20201202211949.17730-1-info@metux.net>

On Wed, Dec 02, 2020 at 10:19:48PM +0100, Enrico Weigelt, metux IT consult wrote:
> Make it possible to opt-out from VMware support, for minimized kernels
> that never will be run under Vmware (eg. high-density virtualization
> or embedded systems).
> 
> Average distro kernel will leave it on, therefore default to y.
> 
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
>  arch/x86/Kconfig                 | 11 +++++++++++
>  arch/x86/kernel/cpu/Makefile     |  4 +++-
>  arch/x86/kernel/cpu/hypervisor.c |  2 ++
>  drivers/input/mouse/Kconfig      |  2 +-
>  drivers/misc/Kconfig             |  2 +-
>  drivers/ptp/Kconfig              |  2 +-
>  6 files changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index f6946b81f74a..eff12460cb3c 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -801,6 +801,17 @@ config X86_HV_CALLBACK_VECTOR
>  
>  source "arch/x86/xen/Kconfig"
>  
> +config VMWARE_GUEST
> +	bool "VMware Guest support"
> +	default y
> +	help
> +	  This option enables several optimizations for running under the
> +	  VMware hypervisor.
> +
> +	  Disabling it saves a few kb, for stripped down kernels eg. in high

I was actually expecting for you to do your own measurements and show data.
Anyway, I did it for you:

   text    data     bss     dec     hex filename
15949304        127806978       36597916        180354198       abffc96 vmlinux.before
15947650        127802430       36602012        180352092       abff45c vmlinux.after

this is with my .config.

How much is it with a stripped down kernel? I bet it is even less. Which
makes this whole effort not worth it...

Also, when you send a new version of your patches, please rework *all*
review feedback you've received on the previous one.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

      parent reply	other threads:[~2020-12-03  7:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 21:19 Enrico Weigelt, metux IT consult
2020-12-02 21:19 ` [PATCH v2 2/2] x86: make Hyper-V " Enrico Weigelt, metux IT consult
2020-12-02 21:58   ` Randy Dunlap
2020-12-02 21:59 ` [PATCH v2 1/2] x86: make VMware " Randy Dunlap
2020-12-03  7:46 ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201203074631.GC3059@zn.tnic \
    --to=bp@alien8.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dragan.cvetic@xilinx.com \
    --cc=hpa@zytor.com \
    --cc=info@metux.net \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v2 1/2] x86: make VMware support optional' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).