From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Ye Xiang <xiang.ye@intel.com>,
jikos@kernel.org, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] iio:Documentation: Add documentation for hinge sensor channels
Date: Sat, 5 Dec 2020 15:52:32 +0000 [thread overview]
Message-ID: <20201205155232.702ce388@archlinux> (raw)
In-Reply-To: <697be63c1500a4ad80651a8182e56ce4271693c1.camel@linux.intel.com>
On Fri, 04 Dec 2020 03:40:15 -0800
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> On Thu, 2020-12-03 at 11:53 +0800, Ye Xiang wrote:
> > Add channel description for hinge sensor, including channel label
> > attribute and raw data description.
> >
> > Signed-off-by: Ye Xiang <xiang.ye@intel.com>
> > ---
> > Documentation/ABI/testing/sysfs-bus-iio | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio
> > b/Documentation/ABI/testing/sysfs-bus-iio
> > index df42bed09f25..82303b1bdff0 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -1802,3 +1802,20 @@ Contact: linux-iio@vger.kernel.org
> > Description:
> > Unscaled light intensity according to CIE 1931/DIN 5033
> > color space.
> > Units after application of scale are nano nanowatts per
> > square meter.
> > +
> > +What: /sys/bus/iio/devices/iio:deviceX/in_anglY_raw
> Channel "Y" doesn't sound to be a variable. Why not just say "*"
Long term convention. More generally you need a way to refer to the
individual wild cards. Sometimes there are more than the two we have
here.
Not entirely sure where the convention comes from but it is used
throughout this file and I doubt I invented it.
Jonathan
>
> Thanks,
> Srinivas
>
> > +KernelVersion: 5.12
> > +Contact: linux-iio@vger.kernel.org
> > +Description:
> > + Angle of rotation for channel Y. Units after
> > application of scale
> > + and offset are radians.
> > +
> > +What: /sys/bus/iio/devices/iio:deviceX/in_anglY_label
> > +KernelVersion: 5.12
> > +Contact: linux-iio@vger.kernel.org
> > +Description:
> > + Optional symbolic label for channel Y.
> > + For Intel hid hinge sensor, the label values are:
> > + hinge, keyboard, screen. It means the three channels
> > + each correspond respectively to hinge angle, keyboard
> > angle,
> > + and screen angle.
>
next prev parent reply other threads:[~2020-12-05 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:53 add custom hinge sensor support Ye Xiang
2020-12-03 3:53 ` [PATCH v3 1/3] HID: hid-sensor-custom: Add custom sensor iio support Ye Xiang
2020-12-05 16:00 ` Jonathan Cameron
2020-12-03 3:53 ` [PATCH v3 2/3] iio: hid-sensors: Add hinge sensor driver Ye Xiang
2020-12-05 16:27 ` Jonathan Cameron
2020-12-03 3:53 ` [PATCH v3 3/3] iio:Documentation: Add documentation for hinge sensor channels Ye Xiang
2020-12-04 11:40 ` Srinivas Pandruvada
2020-12-05 15:52 ` Jonathan Cameron [this message]
2020-12-05 16:05 ` Jonathan Cameron
2020-12-07 9:18 ` Ye, Xiang
2020-12-13 14:15 ` Jonathan Cameron
2020-12-14 6:16 ` Ye, Xiang
2020-12-04 11:46 ` add custom hinge sensor support Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205155232.702ce388@archlinux \
--to=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=xiang.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).