linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Lee Jones" <lee.jones@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>,
	linux-actions@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 4/7] regulator: Add regulator driver for ATC260x PMICs
Date: Tue, 8 Dec 2020 00:54:38 +0200	[thread overview]
Message-ID: <20201207225438.GB250758@ubuntu2004> (raw)
In-Reply-To: <20201207133003.GC5694@sirena.org.uk>

On Mon, Dec 07, 2020 at 01:30:03PM +0000, Mark Brown wrote:
> On Sun, Dec 06, 2020 at 03:27:04AM +0200, Cristian Ciocaltea wrote:
> 
> > +/*
> > + * ATC2603C notes:
> > + * - LDO8 is not documented in datasheet (v2.4), but supported
> > + *   in the vendor's driver implementation (xapp-le-kernel).
> > + * - LDO12 mentioned in datasheet is not programmable, hence not
> > + *   handled in this driver.
> > + */
> 
> No reason not to include LDO12 here, the framework supports fixed
> regulators fine and the bindings should reflect the physical structure
> of the hardware - if something is being supplied by LDO12 on the PMIC
> then you'd expect the binding showing a connection from LDO12.

Totally agree, I will handle this in the next revision.

Thanks,
Cristi

  reply	other threads:[~2020-12-07 22:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06  1:27 [PATCH v3 0/7] Add initial support " Cristian Ciocaltea
2020-12-06  1:27 ` [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property Cristian Ciocaltea
2020-12-10  3:37   ` Rob Herring
2020-12-10  9:13     ` Cristian Ciocaltea
2020-12-11  3:16       ` Rob Herring
2020-12-10  4:06   ` Manivannan Sadhasivam
2020-12-10  9:25     ` Cristian Ciocaltea
2020-12-06  1:27 ` [PATCH v3 2/7] dt-bindings: mfd: Add Actions Semi ATC260x PMIC binding Cristian Ciocaltea
2020-12-11  3:17   ` Rob Herring
2020-12-11 14:17     ` Cristian Ciocaltea
2020-12-06  1:27 ` [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs Cristian Ciocaltea
2020-12-16 10:10   ` Lee Jones
2020-12-17 23:17     ` Cristian Ciocaltea
2020-12-18 13:21       ` Lee Jones
2020-12-18 16:07         ` Cristian Ciocaltea
2020-12-21  8:10           ` Lee Jones
2020-12-21 11:57             ` Cristian Ciocaltea
2020-12-21 12:18               ` Linus Walleij
2020-12-21 13:44                 ` Cristian Ciocaltea
2020-12-06  1:27 ` [PATCH v3 4/7] regulator: Add regulator " Cristian Ciocaltea
2020-12-07 13:30   ` Mark Brown
2020-12-07 22:54     ` Cristian Ciocaltea [this message]
2020-12-06  1:27 ` [PATCH v3 5/7] power: reset: Add poweroff " Cristian Ciocaltea
2020-12-06  1:27 ` [PATCH v3 6/7] input: atc260x: Add onkey " Cristian Ciocaltea
2020-12-06  3:13   ` Dmitry Torokhov
2020-12-06 13:44     ` Cristian Ciocaltea
2020-12-06  1:27 ` [PATCH v3 7/7] MAINTAINERS: Add entry for ATC260x PMIC Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207225438.GB250758@ubuntu2004 \
    --to=cristian.ciocaltea@gmail.com \
    --cc=afaerber@suse.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --subject='Re: [PATCH v3 4/7] regulator: Add regulator driver for ATC260x PMICs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).