From: Will Deacon <will@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Jiri Kosina <jkosina@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrea Borgia <andrea@borgia.bo.it>,
Rob Herring <robh+dt@kernel.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Stephen Boyd <swboyd@chromium.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Aaron Ma <aaron.ma@canonical.com>,
Anson Huang <Anson.Huang@nxp.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jiri Kosina <jikos@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Li Yang <leoyang.li@nxp.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michael Walle <michael@walle.cc>, Olof Johansson <olof@lixom.net>,
Pavel Balan <admin@kryma.net>, Shawn Guo <shawnguo@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Xiaofei Tan <tanxiaofei@huawei.com>,
You-Sheng Yang <vicamo.yang@canonical.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p
Date: Tue, 8 Dec 2020 16:00:29 +0000 [thread overview]
Message-ID: <20201208160029.GA6461@willie-the-truck> (raw)
In-Reply-To: <CAD=FV=VkyF8B9stozXv_Xt7a-Od4-1f2h6QS5DDekiZCQhXjgw@mail.gmail.com>
On Wed, Dec 02, 2020 at 07:54:40AM -0800, Doug Anderson wrote:
> On Wed, Dec 2, 2020 at 7:20 AM Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> > On Tue, Dec 1, 2020 at 10:12 PM Doug Anderson <dianders@chromium.org> wrote:
> > > On Wed, Nov 11, 2020 at 4:41 PM Douglas Anderson <dianders@chromium.org> wrote:
> > > > .../bindings/input/goodix,gt7375p.yaml | 65 +++++
> > > > arch/arm64/configs/defconfig | 3 +-
> > > > drivers/hid/Makefile | 2 +-
> > > > drivers/hid/i2c-hid/Kconfig | 47 +++-
> > > > drivers/hid/i2c-hid/Makefile | 6 +-
> > > > drivers/hid/i2c-hid/i2c-hid-acpi.c | 159 +++++++++++
> > > > drivers/hid/i2c-hid/i2c-hid-core.c | 254 +++---------------
> > > > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 116 ++++++++
> > > > drivers/hid/i2c-hid/i2c-hid-of.c | 143 ++++++++++
> > > > drivers/hid/i2c-hid/i2c-hid.h | 22 ++
> > > > include/linux/platform_data/i2c-hid.h | 41 ---
> > > > 11 files changed, 596 insertions(+), 262 deletions(-)
> > > > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> > > > create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c
> > > > create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> > > > create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c
> > > > delete mode 100644 include/linux/platform_data/i2c-hid.h
> > >
> > > Are there any additional changes that folks would like with this
> > > series? It's not crazy urgent to get it in, but it touches enough
> > > lines of code that it'd be nice to get it in before other patches land
> > > and it gets merge conflicts.
> >
> > Sorry for the delay. I was having an internal deadline last week. I
> > just re-read the code, and I am quite happy with it. I also just
> > tested it on the i2c-hid w/ acpi machine I have here, and it seems OK.
> >
> > So other than that, do we need to have approvals for patch 2/4
> > (arch/arm64/configs/defconfig)? I can easily take that in the HID
> > tree, but I prefer having the approval from the maintainers first.
> > Catalin, Will?
>
> From my past knowledge of the arm64 defconfig, I think it's a bit of a
> free-for-all, sort of like updates to the "MAINTAINERS" file. Doing a
> "git log" on it I see commits happen from every corner and very few of
> them have Acks. I think many (but not all) of the commits to this
> file go through trees that feed into the SoC tree (Arnd and Olof)
> because those maintainers care about enabling drivers for boards that
> they're supporting, but changes come from elsewhere too.
>
> Obviously an Ack wouldn't hurt, though. Since get_maintainer points
> at Will and Catalin I wouldn't say no if one of them wanted to Ack
> patch #2 in the series. ;-)
For the avoidance of doubt:
Acked-by: Will Deacon <will@kernel.org>
on patch 2. But yes, although there are a few things I really care about
in defconfig (e.g. things like page size!), generally speaking we don't
need to Ack everything that changes in there.
That said, might be worth checking whether arm-soc have any defconfig
changes queued in -next so you don't end up with conflicts.
Will
prev parent reply other threads:[~2020-12-08 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 0:41 [PATCH v6 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Douglas Anderson
2020-11-12 0:41 ` [PATCH v6 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules Douglas Anderson
2020-11-12 0:41 ` [PATCH v6 2/4] arm64: defconfig: Update config names for i2c-hid rejigger Douglas Anderson
2020-11-12 0:41 ` [PATCH v6 3/4] dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-11-12 0:41 ` [PATCH v6 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core Douglas Anderson
2020-12-01 21:12 ` [PATCH v6 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Doug Anderson
2020-12-02 15:19 ` Benjamin Tissoires
2020-12-02 15:54 ` Doug Anderson
2020-12-08 16:00 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208160029.GA6461@willie-the-truck \
--to=will@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=aaron.ma@canonical.com \
--cc=admin@kryma.net \
--cc=andrea@borgia.bo.it \
--cc=benjamin.tissoires@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=krzk@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michael@walle.cc \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=swboyd@chromium.org \
--cc=tanxiaofei@huawei.com \
--cc=vicamo.yang@canonical.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).