From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
linux-actions@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property
Date: Thu, 10 Dec 2020 11:25:35 +0200 [thread overview]
Message-ID: <20201210092535.GB322060@ubuntu2004> (raw)
In-Reply-To: <20201210040644.GC6466@thinkpad>
Hi Mani,
On Thu, Dec 10, 2020 at 09:36:44AM +0530, Manivannan Sadhasivam wrote:
> On Sun, Dec 06, 2020 at 03:27:01AM +0200, Cristian Ciocaltea wrote:
> > Add a new common property 'reset-time-sec' to be used in conjunction
> > with the devices supporting the key pressed reset feature.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > ---
> > Changes in v3:
> > - This patch was not present in v2
> >
> > Documentation/devicetree/bindings/input/input.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> > index ab407f266bef..caba93209ae7 100644
> > --- a/Documentation/devicetree/bindings/input/input.yaml
> > +++ b/Documentation/devicetree/bindings/input/input.yaml
> > @@ -34,4 +34,11 @@ properties:
> > specify this property.
> > $ref: /schemas/types.yaml#/definitions/uint32
> >
> > + reset-time-sec:
> > + description:
> > + Duration in seconds which the key should be kept pressed for device to
> > + reset automatically. Device with key pressed reset feature can specify
> > + this property.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
>
> Why can't you just use "power-off-time-sec"?
I think the common behavior of keeping the power button pressed is to
trigger a power off rather than a reset. Hence, per Rob's suggestion in
the previous revision of this patch series, I added the reset variant:
https://lore.kernel.org/lkml/20200908214724.GA959481@bogus/
Thanks,
Cristi
> Thanks,
> Mani
>
> > additionalProperties: true
> > --
> > 2.29.2
> >
next prev parent reply other threads:[~2020-12-10 9:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 1:27 [PATCH v3 0/7] Add initial support for ATC260x PMICs Cristian Ciocaltea
2020-12-06 1:27 ` [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property Cristian Ciocaltea
2020-12-10 3:37 ` Rob Herring
2020-12-10 9:13 ` Cristian Ciocaltea
2020-12-11 3:16 ` Rob Herring
2020-12-10 4:06 ` Manivannan Sadhasivam
2020-12-10 9:25 ` Cristian Ciocaltea [this message]
2020-12-06 1:27 ` [PATCH v3 2/7] dt-bindings: mfd: Add Actions Semi ATC260x PMIC binding Cristian Ciocaltea
2020-12-11 3:17 ` Rob Herring
2020-12-11 14:17 ` Cristian Ciocaltea
2020-12-06 1:27 ` [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs Cristian Ciocaltea
2020-12-16 10:10 ` Lee Jones
2020-12-17 23:17 ` Cristian Ciocaltea
2020-12-18 13:21 ` Lee Jones
2020-12-18 16:07 ` Cristian Ciocaltea
2020-12-21 8:10 ` Lee Jones
2020-12-21 11:57 ` Cristian Ciocaltea
2020-12-21 12:18 ` Linus Walleij
2020-12-21 13:44 ` Cristian Ciocaltea
2020-12-06 1:27 ` [PATCH v3 4/7] regulator: Add regulator " Cristian Ciocaltea
2020-12-07 13:30 ` Mark Brown
2020-12-07 22:54 ` Cristian Ciocaltea
2020-12-06 1:27 ` [PATCH v3 5/7] power: reset: Add poweroff " Cristian Ciocaltea
2020-12-06 1:27 ` [PATCH v3 6/7] input: atc260x: Add onkey " Cristian Ciocaltea
2020-12-06 3:13 ` Dmitry Torokhov
2020-12-06 13:44 ` Cristian Ciocaltea
2020-12-06 1:27 ` [PATCH v3 7/7] MAINTAINERS: Add entry for ATC260x PMIC Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210092535.GB322060@ubuntu2004 \
--to=cristian.ciocaltea@gmail.com \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--subject='Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).