From: Marco Felsch <m.felsch@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Simon Budig <simon.budig@kernelconcepts.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes
Date: Thu, 10 Dec 2020 11:08:03 +0100 [thread overview]
Message-ID: <20201210100803.bfohc5fglvrwrtcz@pengutronix.de> (raw)
In-Reply-To: <X9FZFs3NZADoIhhH@google.com>
Hi Dmitry,
On 20-12-09 15:09, Dmitry Torokhov wrote:
> Instead of using special-casing retrieval of number of X/Y electrodes
> based on the firmware, let's select default values and mark registers as
> non-existent on firmwares that do not support this operation.
>
> Also mark "report rate" register as non-existent for generic firmwares as
> having it set to 0 does not make sense.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/touchscreen/edt-ft5x06.c | 43 ++++++++++----------------
> 1 file changed, 17 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index 6ff81d48da86..2eefbc2485bc 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -69,6 +69,9 @@
...
> case EV_FT:
> reg_addr->reg_threshold = EV_REGISTER_THRESHOLD;
> + reg_addr->reg_report_rate = NO_REGISTER;
> reg_addr->reg_gain = EV_REGISTER_GAIN;
> reg_addr->reg_offset = NO_REGISTER;
> reg_addr->reg_offset_x = EV_REGISTER_OFFSET_X;
> reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y;
> reg_addr->reg_num_x = NO_REGISTER;
> reg_addr->reg_num_y = NO_REGISTER;
> - reg_addr->reg_report_rate = NO_REGISTER;
> break;
Nit:
Unrelated change.
However the patch looks good, thanks.
Acked-by: Marco Felsch <m.felsch@pengutronix.de>
Regards,
Marco
next prev parent reply other threads:[~2020-12-10 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 23:09 Dmitry Torokhov
2020-12-10 9:50 ` Andy Shevchenko
2020-12-10 10:08 ` Marco Felsch [this message]
2020-12-10 11:33 ` Andy Shevchenko
2020-12-10 12:29 ` Simon Budig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210100803.bfohc5fglvrwrtcz@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=simon.budig@kernelconcepts.de \
--subject='Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).