From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Simon Budig <simon.budig@kernelconcepts.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes
Date: Thu, 10 Dec 2020 13:33:34 +0200 [thread overview]
Message-ID: <20201210113334.GD4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201210100803.bfohc5fglvrwrtcz@pengutronix.de>
On Thu, Dec 10, 2020 at 11:08:03AM +0100, Marco Felsch wrote:
> On 20-12-09 15:09, Dmitry Torokhov wrote:
...
> > case EV_FT:
> > reg_addr->reg_threshold = EV_REGISTER_THRESHOLD;
> > + reg_addr->reg_report_rate = NO_REGISTER;
> > reg_addr->reg_gain = EV_REGISTER_GAIN;
> > reg_addr->reg_offset = NO_REGISTER;
> > reg_addr->reg_offset_x = EV_REGISTER_OFFSET_X;
> > reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y;
> > reg_addr->reg_num_x = NO_REGISTER;
> > reg_addr->reg_num_y = NO_REGISTER;
> > - reg_addr->reg_report_rate = NO_REGISTER;
> > break;
>
> Nit:
> Unrelated change.
I guess the motive is to get these assignments consistent between the cases.
Documentation actually allows this kind of modifications of code in one change
when them are toughly related.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-12-10 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 23:09 [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes Dmitry Torokhov
2020-12-10 9:50 ` Andy Shevchenko
2020-12-10 10:08 ` Marco Felsch
2020-12-10 11:33 ` Andy Shevchenko [this message]
2020-12-10 12:29 ` Simon Budig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210113334.GD4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=simon.budig@kernelconcepts.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).