From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B4FC4361B for ; Mon, 14 Dec 2020 06:16:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DB8E20791 for ; Mon, 14 Dec 2020 06:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438653AbgLNGQg (ORCPT ); Mon, 14 Dec 2020 01:16:36 -0500 Received: from mga09.intel.com ([134.134.136.24]:26776 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727746AbgLNGQg (ORCPT ); Mon, 14 Dec 2020 01:16:36 -0500 IronPort-SDR: we7a68v8zloUiToOIbPjWTD3l6nS6TR7YEnnHYHKdw3leb9GwZLrNwG4HZrpQ1nY6tIAKln1dj NTCku+5IRZ+A== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="174805464" X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="174805464" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2020 22:15:53 -0800 IronPort-SDR: 77inXdLATyLP18YxtOXyKK5PijU3N34hp3XjfdiZE9aAyRLkJHOQcuDy8ELDLAHhWsyYrOOIK8 OqIK5VEIfiAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="486886677" Received: from host.sh.intel.com (HELO host) ([10.239.154.115]) by orsmga004.jf.intel.com with ESMTP; 13 Dec 2020 22:15:51 -0800 Date: Mon, 14 Dec 2020 14:16:40 +0800 From: "Ye, Xiang" To: Jonathan Cameron Cc: jikos@kernel.org, srinivas.pandruvada@linux.intel.com, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] iio:Documentation: Add documentation for hinge sensor channels Message-ID: <20201214061640.GA28333@host> References: <20201203035352.13918-1-xiang.ye@intel.com> <20201203035352.13918-4-xiang.ye@intel.com> <20201205160540.22d2b8d5@archlinux> <20201207091818.GA23419@host> <20201213141545.1e9d30de@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201213141545.1e9d30de@archlinux> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Sun, Dec 13, 2020 at 02:15:45PM +0000, Jonathan Cameron wrote: > On Mon, 7 Dec 2020 17:18:18 +0800 > "Ye, Xiang" wrote: > > > Hi Jonathan > > > > Thanks for review and comments. > > > > On Sat, Dec 05, 2020 at 04:05:40PM +0000, Jonathan Cameron wrote: > > > On Thu, 3 Dec 2020 11:53:52 +0800 > > > Ye Xiang wrote: > > > > > > > Add channel description for hinge sensor, including channel label > > > > attribute and raw data description. > > > > > > > > Signed-off-by: Ye Xiang > > > > --- > > > > Documentation/ABI/testing/sysfs-bus-iio | 17 +++++++++++++++++ > > > > 1 file changed, 17 insertions(+) > > > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > > > > index df42bed09f25..82303b1bdff0 100644 > > > > --- a/Documentation/ABI/testing/sysfs-bus-iio > > > > +++ b/Documentation/ABI/testing/sysfs-bus-iio > > > > @@ -1802,3 +1802,20 @@ Contact: linux-iio@vger.kernel.org > > > > Description: > > > > Unscaled light intensity according to CIE 1931/DIN 5033 color space. > > > > Units after application of scale are nano nanowatts per square meter. > > > > + > > > > +What: /sys/bus/iio/devices/iio:deviceX/in_anglY_raw > > > > +KernelVersion: 5.12 > > > > +Contact: linux-iio@vger.kernel.org > > > > +Description: > > > > + Angle of rotation for channel Y. Units after application of scale > > > > + and offset are radians. > > > > > > This entry is already mostly in the doc around line 200, just without the index. > > > Please just add the What: line to that block to reduce repetition. > > > If you want to add... "Where present, Y indexes the channel." or something like > > > that feel free. > > When adding in_anglY_raw to in_angl_raw block, Should I update the KernelVersion form > > 4.17 to 5.12? Like blow: > > > > What: /sys/bus/iio/devices/iio:deviceX/in_angl_raw > > What: /sys/bus/iio/devices/iio:deviceX/in_anglY_raw > > KernelVersion: 5.12 > > Contact: linux-iio@vger.kernel.org > > Description: > > Angle of rotation. Units after application of scale and offset > > are radians. Where present, Y indexes the channel. > > No. This is an unfortunate limitation of these files unless we keep duplicating > nearly identical text. > > I'm not that worried about documenting an optional bit of ABI as apparently > being in an earlier kernel than it actually was. That way any userspace > will work. The other way around is more likely to cause problems. Got it, then I will keep KernelVersion 4.17. will send the next version out for review soon. Thanks again for the review. > > > > > > > > > > > > > + > > > > +What: /sys/bus/iio/devices/iio:deviceX/in_anglY_label > > > > +KernelVersion: 5.12 > > > > +Contact: linux-iio@vger.kernel.org > > > > +Description: > > > > + Optional symbolic label for channel Y. > > > > + For Intel hid hinge sensor, the label values are: > > > > + hinge, keyboard, screen. It means the three channels > > > > + each correspond respectively to hinge angle, keyboard angle, > > > > + and screen angle. > > > > > > Makes sense to keep this block separate given the additional info provided. > > > Alternative would be to add it to the one with in_voltageY_label which would > > > be odd given what follows! > > Ok, Then I will keep the in_anglY_label block here. BTW, I didnot see in_voltageY_label > > in sysfs-bus-iio in current kernel master branch. > It was part of the series that added the support for per channel labels to the core. > 3079188f821c ("iio:Documentation: Add documentation for label channel attribute") > so will only going into current master in the merge window that will open shortly. got it. > Thanks Ye, Xiang