* [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon
@ 2020-12-14 13:32 Zheng Yongjun
2020-12-14 14:13 ` Srinivas Pandruvada
0 siblings, 1 reply; 6+ messages in thread
From: Zheng Yongjun @ 2020-12-14 13:32 UTC (permalink / raw)
To: jikos, jic23, srinivas.pandruvada, benjamin.tissoires
Cc: linux-input, linux-iio, linux-kernel, Zheng Yongjun
Replace a comma between expression statements by a semicolon.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/hid/hid-sensor-custom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
index 4d25577a8573..6c47a2e7623d 100644
--- a/drivers/hid/hid-sensor-custom.c
+++ b/drivers/hid/hid-sensor-custom.c
@@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct hid_sensor_custom *sensor_inst)
sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev->dev);
- sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
+ sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
ret = misc_register(&sensor_inst->custom_dev);
if (ret) {
kfifo_free(&sensor_inst->data_fifo);
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon
2020-12-14 13:32 [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon Zheng Yongjun
@ 2020-12-14 14:13 ` Srinivas Pandruvada
2020-12-29 18:18 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Srinivas Pandruvada @ 2020-12-14 14:13 UTC (permalink / raw)
To: Zheng Yongjun, jikos, jic23, benjamin.tissoires
Cc: linux-input, linux-iio, linux-kernel
On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/hid-sensor-custom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> sensor-custom.c
> index 4d25577a8573..6c47a2e7623d 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> hid_sensor_custom *sensor_inst)
>
> sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-
> >dev);
> - sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> + sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> ret = misc_register(&sensor_inst->custom_dev);
> if (ret) {
> kfifo_free(&sensor_inst->data_fifo);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon
2020-12-14 14:13 ` Srinivas Pandruvada
@ 2020-12-29 18:18 ` Jonathan Cameron
2021-01-20 20:49 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2020-12-29 18:18 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Zheng Yongjun, jikos, benjamin.tissoires, linux-input, linux-iio,
linux-kernel
On Mon, 14 Dec 2020 06:13:58 -0800
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if they can break it.
Thanks,
Jonathan
>
> > ---
> > drivers/hid/hid-sensor-custom.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > sensor-custom.c
> > index 4d25577a8573..6c47a2e7623d 100644
> > --- a/drivers/hid/hid-sensor-custom.c
> > +++ b/drivers/hid/hid-sensor-custom.c
> > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > hid_sensor_custom *sensor_inst)
> >
> > sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> > sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-
> > >dev);
> > - sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > + sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> > ret = misc_register(&sensor_inst->custom_dev);
> > if (ret) {
> > kfifo_free(&sensor_inst->data_fifo);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon
2020-12-29 18:18 ` Jonathan Cameron
@ 2021-01-20 20:49 ` Jonathan Cameron
2021-01-22 8:54 ` Jonathan Cameron
2021-01-22 10:58 ` Jiri Kosina
0 siblings, 2 replies; 6+ messages in thread
From: Jonathan Cameron @ 2021-01-20 20:49 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Zheng Yongjun, jikos, benjamin.tissoires, linux-input, linux-iio,
linux-kernel
On Tue, 29 Dec 2020 18:18:41 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Mon, 14 Dec 2020 06:13:58 -0800
> Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
>
> > On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> > > Replace a comma between expression statements by a semicolon.
> > >
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to see if they can break it.
Hi Jiri,
Just realised this is in HID rather than IIO. I hope you don't mind as
it's now deep in a tree I'd rather not rebase.
Sorry about that.
Jonathan
>
> Thanks,
>
> Jonathan
>
> >
> > > ---
> > > drivers/hid/hid-sensor-custom.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > > sensor-custom.c
> > > index 4d25577a8573..6c47a2e7623d 100644
> > > --- a/drivers/hid/hid-sensor-custom.c
> > > +++ b/drivers/hid/hid-sensor-custom.c
> > > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > > hid_sensor_custom *sensor_inst)
> > >
> > > sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> > > sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-
> > > >dev);
> > > - sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > > + sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> > > ret = misc_register(&sensor_inst->custom_dev);
> > > if (ret) {
> > > kfifo_free(&sensor_inst->data_fifo);
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon
2021-01-20 20:49 ` Jonathan Cameron
@ 2021-01-22 8:54 ` Jonathan Cameron
2021-01-22 10:58 ` Jiri Kosina
1 sibling, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2021-01-22 8:54 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Zheng Yongjun, jikos, benjamin.tissoires, linux-input, linux-iio,
linux-kernel
On Wed, 20 Jan 2021 20:49:57 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 29 Dec 2020 18:18:41 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Mon, 14 Dec 2020 06:13:58 -0800
> > Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> >
> > > On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> > > > Replace a comma between expression statements by a semicolon.
> > > >
> > > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to see if they can break it.
> Hi Jiri,
>
> Just realised this is in HID rather than IIO. I hope you don't mind as
> it's now deep in a tree I'd rather not rebase.
On basis it wasn't actually that bad, (only one merge after it) I did
the rebase and dropped this patch. Jiri, guess you probably
want to pick this up through HID.
Thanks,
Jonathan
>
> Sorry about that.
>
> Jonathan
>
> >
> > Thanks,
> >
> > Jonathan
> >
> > >
> > > > ---
> > > > drivers/hid/hid-sensor-custom.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > > > sensor-custom.c
> > > > index 4d25577a8573..6c47a2e7623d 100644
> > > > --- a/drivers/hid/hid-sensor-custom.c
> > > > +++ b/drivers/hid/hid-sensor-custom.c
> > > > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > > > hid_sensor_custom *sensor_inst)
> > > >
> > > > sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> > > > sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-
> > > > >dev);
> > > > - sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > > > + sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> > > > ret = misc_register(&sensor_inst->custom_dev);
> > > > if (ret) {
> > > > kfifo_free(&sensor_inst->data_fifo);
> > >
> > >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon
2021-01-20 20:49 ` Jonathan Cameron
2021-01-22 8:54 ` Jonathan Cameron
@ 2021-01-22 10:58 ` Jiri Kosina
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2021-01-22 10:58 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Srinivas Pandruvada, Zheng Yongjun, benjamin.tissoires,
linux-input, linux-iio, linux-kernel
On Wed, 20 Jan 2021, Jonathan Cameron wrote:
> > > > Replace a comma between expression statements by a semicolon.
> > > >
> > > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to see if they can break it.
> Hi Jiri,
>
> Just realised this is in HID rather than IIO. I hope you don't mind as
> it's now deep in a tree I'd rather not rebase.
>
> Sorry about that.
No worries, feel free to keep it in your tree.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-22 11:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 13:32 [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon Zheng Yongjun
2020-12-14 14:13 ` Srinivas Pandruvada
2020-12-29 18:18 ` Jonathan Cameron
2021-01-20 20:49 ` Jonathan Cameron
2021-01-22 8:54 ` Jonathan Cameron
2021-01-22 10:58 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).