From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> To: Lee Jones <lee.jones@linaro.org> Cc: "Rob Herring" <robh+dt@kernel.org>, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Sebastian Reichel" <sre@kernel.org>, "Mark Brown" <broonie@kernel.org>, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>, "Liam Girdwood" <lgirdwood@gmail.com>, "Andreas Färber" <afaerber@suse.de>, linux-actions@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs Date: Mon, 21 Dec 2020 13:57:13 +0200 [thread overview] Message-ID: <20201221115713.GA155203@BV030612LT> (raw) In-Reply-To: <20201221081015.GA4825@dell> On Mon, Dec 21, 2020 at 08:10:15AM +0000, Lee Jones wrote: > On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > > > On Fri, Dec 18, 2020 at 01:21:39PM +0000, Lee Jones wrote: > > > On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > > > > > > > Hi Lee, > > > > > > > > Thank you for the detailed review! > > > > > > > > I will prepare a new revision, but there are still a couple of open > > > > points.. > > > > > > Could you please snip your replies, leaving only the open points. > > > > > > Scrolling through lots of empty quotes or "done" comments is quite > > > time consuming. Thanks. > > > > Sure, I'll take that into account. > > > > > [...] > > > > > > > > > + ret = regmap_read(atc260x->regmap, atc260x->rev_reg, &chip_rev); > > > > > > + if (ret) { > > > > > > + dev_err(dev, "Failed to get chip revision\n"); > > > > > > + return ret; > > > > > > + } > > > > > > + > > > > > > + if (chip_rev < 0 || chip_rev > 31) { > > > > > > + dev_err(dev, "Unknown chip revision: %d\n", ret); > > > > > > + return -EINVAL; > > > > > > + } > > > > > > > > > > This still seems limiting. > > > > > > > > This is based on the vendor implementation. Unfortunately I don't have > > > > access to a data sheet or any other source of information about the > > > > management of the chip revisions. > > > > > > So which versions does this driver work with? All 32? > > > > I'm not even sure there are so many revisions, I guess that's just a > > rough validation for a vendor reserved range. > > > > For the moment, the only place where the functionality is affected > > by the chip revision is in the regulator driver - there is a special > > handling for the ATC2603C rev.B chip variant. > > > > I expect some additional handling might be required for new drivers > > bringing support for the other functions provided by the hardware. > > The current patch seems to insinuate that 32 versions are currently > supported. What is the chip_rev for the ATC2603C rev.B? I only own the rev.A for the ATC2603C variant, for which I read '0' from the chip rev register. However what really matters for the driver is not the raw value, but the one computed via: atc260x->ic_ver = __ffs(chip_rev + 1U); This is basically a translation of the raw value to a chip version that is used in the context of the special handling mentioned above: enum atc260x_ver { ATC260X_A = 0, ATC260X_B, ATC260X_C, ATC260X_D, ATC260X_E, ATC260X_F, ATC260X_G, ATC260X_H, }; So we actually could handle up to 8 chip versions with the current management scheme. > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-12-21 11:58 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-06 1:27 [PATCH v3 0/7] Add initial support " Cristian Ciocaltea 2020-12-06 1:27 ` [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property Cristian Ciocaltea 2020-12-10 3:37 ` Rob Herring 2020-12-10 9:13 ` Cristian Ciocaltea 2020-12-11 3:16 ` Rob Herring 2020-12-10 4:06 ` Manivannan Sadhasivam 2020-12-10 9:25 ` Cristian Ciocaltea 2020-12-06 1:27 ` [PATCH v3 2/7] dt-bindings: mfd: Add Actions Semi ATC260x PMIC binding Cristian Ciocaltea 2020-12-11 3:17 ` Rob Herring 2020-12-11 14:17 ` Cristian Ciocaltea 2020-12-06 1:27 ` [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs Cristian Ciocaltea 2020-12-16 10:10 ` Lee Jones 2020-12-17 23:17 ` Cristian Ciocaltea 2020-12-18 13:21 ` Lee Jones 2020-12-18 16:07 ` Cristian Ciocaltea 2020-12-21 8:10 ` Lee Jones 2020-12-21 11:57 ` Cristian Ciocaltea [this message] 2020-12-21 12:18 ` Linus Walleij 2020-12-21 13:44 ` Cristian Ciocaltea 2020-12-06 1:27 ` [PATCH v3 4/7] regulator: Add regulator " Cristian Ciocaltea 2020-12-07 13:30 ` Mark Brown 2020-12-07 22:54 ` Cristian Ciocaltea 2020-12-06 1:27 ` [PATCH v3 5/7] power: reset: Add poweroff " Cristian Ciocaltea 2020-12-06 1:27 ` [PATCH v3 6/7] input: atc260x: Add onkey " Cristian Ciocaltea 2020-12-06 3:13 ` Dmitry Torokhov 2020-12-06 13:44 ` Cristian Ciocaltea 2020-12-06 1:27 ` [PATCH v3 7/7] MAINTAINERS: Add entry for ATC260x PMIC Cristian Ciocaltea
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201221115713.GA155203@BV030612LT \ --to=cristian.ciocaltea@gmail.com \ --cc=afaerber@suse.de \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-actions@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=manivannan.sadhasivam@linaro.org \ --cc=robh+dt@kernel.org \ --cc=sre@kernel.org \ --subject='Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).