* [PATCH] input, i8042: unbreak Pegatron C15B
@ 2020-12-28 7:23 Alexey Dobriyan
2020-12-28 7:48 ` ACK: " Po-Hsu Lin
2021-01-04 22:56 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2020-12-28 7:23 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, po-hsu.lin
g++ reports
drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list
C99 semantics is that last duplicated initialiser wins,
so DMI entry gets overwritten.
Fixes: a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/input/serio/i8042-x86ia64io.h | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -219,6 +219,8 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
DMI_MATCH(DMI_SYS_VENDOR, "PEGATRON CORPORATION"),
DMI_MATCH(DMI_PRODUCT_NAME, "C15B"),
},
+ },
+ {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "ByteSpeed LLC"),
DMI_MATCH(DMI_PRODUCT_NAME, "ByteSpeed Laptop C15B"),
^ permalink raw reply [flat|nested] 3+ messages in thread* ACK: [PATCH] input, i8042: unbreak Pegatron C15B
2020-12-28 7:23 [PATCH] input, i8042: unbreak Pegatron C15B Alexey Dobriyan
@ 2020-12-28 7:48 ` Po-Hsu Lin
2021-01-04 22:56 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Po-Hsu Lin @ 2020-12-28 7:48 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input
LGTM, thanks for spotting this!
Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] input, i8042: unbreak Pegatron C15B
2020-12-28 7:23 [PATCH] input, i8042: unbreak Pegatron C15B Alexey Dobriyan
2020-12-28 7:48 ` ACK: " Po-Hsu Lin
@ 2021-01-04 22:56 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2021-01-04 22:56 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-input, po-hsu.lin
On Mon, Dec 28, 2020 at 10:23:35AM +0300, Alexey Dobriyan wrote:
> g++ reports
>
> drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list
>
> C99 semantics is that last duplicated initialiser wins,
> so DMI entry gets overwritten.
>
> Fixes: a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-04 23:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-28 7:23 [PATCH] input, i8042: unbreak Pegatron C15B Alexey Dobriyan
2020-12-28 7:48 ` ACK: " Po-Hsu Lin
2021-01-04 22:56 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).