From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B27A0C433E0 for ; Wed, 30 Dec 2020 12:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E4C322209 for ; Wed, 30 Dec 2020 12:06:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbgL3MGC (ORCPT ); Wed, 30 Dec 2020 07:06:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:44840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbgL3MGC (ORCPT ); Wed, 30 Dec 2020 07:06:02 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 626642074D; Wed, 30 Dec 2020 12:05:20 +0000 (UTC) Date: Wed, 30 Dec 2020 12:05:17 +0000 From: Jonathan Cameron To: Ye Xiang Cc: jikos@kernel.org, srinivas.pandruvada@linux.intel.com, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] add custom hinge sensor support Message-ID: <20201230120517.622d3351@archlinux> In-Reply-To: <20201215054444.9324-1-xiang.ye@intel.com> References: <20201215054444.9324-1-xiang.ye@intel.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, 15 Dec 2020 13:44:41 +0800 Ye Xiang wrote: > Here we register one iio device with three channels which present angle for > hinge, keyboard and screen. > > This driver works on devices with Intel integrated sensor hub, where > hinge sensor is presented using a custom sensor usage id. > > Here the angle is presented in degrees, which is converted to radians. Other than those minor bits I'm happy to fix up in patch 2, this looks good to me. However, I'll need a Jiri Ack for the hid parts before I apply it. We are are early in this cycle, so no great rush given the usual xmas slow down! Thanks, Jonathan > > Changes since v3: > - hid-sensor-custom: remove sensor_inst::custom_pdev_exposed. > - hid-sensor-custom: use static buf, w_buf to avoid using goto in > get_known_custom_sensor_index. > - hid-sensor-custom-intel-hinge: use devm_ prefix function instead. > - sysfs-bus-iio: put in_anglY_raw together with in_angl_raw. > > Changes since v2: > - use 1 iio device instead of 3 for hinge sensor. > - use indexed channel instead of modified channel and added channel > labels. > - remove 2,3 patch in last version, add a document patch to describe the > hinge channels. > - hid-sensor-custom: use meaningful return value in > get_known_custom_sensor_index and checked in call side. > - hid-sensor-ids.h: use HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x) to > define custom sensor value. > > Changes since v1: > - fixed errors reported by lkp > > Ye Xiang (3): > HID: hid-sensor-custom: Add custom sensor iio support > iio: hid-sensors: Add hinge sensor driver > iio:Documentation: Add documentation for hinge sensor channels > > Documentation/ABI/testing/sysfs-bus-iio | 11 + > drivers/hid/hid-sensor-custom.c | 143 +++++++ > .../hid-sensors/hid-sensor-attributes.c | 2 + > drivers/iio/position/Kconfig | 16 + > drivers/iio/position/Makefile | 1 + > .../position/hid-sensor-custom-intel-hinge.c | 391 ++++++++++++++++++ > include/linux/hid-sensor-ids.h | 14 + > 7 files changed, 578 insertions(+) > create mode 100644 drivers/iio/position/hid-sensor-custom-intel-hinge.c >