From: "Ye, Xiang" <xiang.ye@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: jikos@kernel.org, srinivas.pandruvada@linux.intel.com,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] add custom hinge sensor support
Date: Thu, 31 Dec 2020 10:46:40 +0800 [thread overview]
Message-ID: <20201231024640.GA5718@host> (raw)
In-Reply-To: <20201230120517.622d3351@archlinux>
On Wed, Dec 30, 2020 at 12:05:17PM +0000, Jonathan Cameron wrote:
> On Tue, 15 Dec 2020 13:44:41 +0800
> Ye Xiang <xiang.ye@intel.com> wrote:
>
> > Here we register one iio device with three channels which present angle for
> > hinge, keyboard and screen.
> >
> > This driver works on devices with Intel integrated sensor hub, where
> > hinge sensor is presented using a custom sensor usage id.
> >
> > Here the angle is presented in degrees, which is converted to radians.
>
> Other than those minor bits I'm happy to fix up in patch 2, this looks
> good to me. However, I'll need a Jiri Ack for the hid parts before
> I apply it. We are are early in this cycle, so no great rush given
> the usual xmas slow down!
Ok, let's wait Jiri to review the hid parts. Thanks for the help.
Thanks
Ye Xiang
>
> >
> > Changes since v3:
> > - hid-sensor-custom: remove sensor_inst::custom_pdev_exposed.
> > - hid-sensor-custom: use static buf, w_buf to avoid using goto in
> > get_known_custom_sensor_index.
> > - hid-sensor-custom-intel-hinge: use devm_ prefix function instead.
> > - sysfs-bus-iio: put in_anglY_raw together with in_angl_raw.
> >
> > Changes since v2:
> > - use 1 iio device instead of 3 for hinge sensor.
> > - use indexed channel instead of modified channel and added channel
> > labels.
> > - remove 2,3 patch in last version, add a document patch to describe the
> > hinge channels.
> > - hid-sensor-custom: use meaningful return value in
> > get_known_custom_sensor_index and checked in call side.
> > - hid-sensor-ids.h: use HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x) to
> > define custom sensor value.
> >
> > Changes since v1:
> > - fixed errors reported by lkp
> >
> > Ye Xiang (3):
> > HID: hid-sensor-custom: Add custom sensor iio support
> > iio: hid-sensors: Add hinge sensor driver
> > iio:Documentation: Add documentation for hinge sensor channels
> >
> > Documentation/ABI/testing/sysfs-bus-iio | 11 +
> > drivers/hid/hid-sensor-custom.c | 143 +++++++
> > .../hid-sensors/hid-sensor-attributes.c | 2 +
> > drivers/iio/position/Kconfig | 16 +
> > drivers/iio/position/Makefile | 1 +
> > .../position/hid-sensor-custom-intel-hinge.c | 391 ++++++++++++++++++
> > include/linux/hid-sensor-ids.h | 14 +
> > 7 files changed, 578 insertions(+)
> > create mode 100644 drivers/iio/position/hid-sensor-custom-intel-hinge.c
> >
>
next prev parent reply other threads:[~2020-12-31 2:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 5:44 [PATCH v4 0/3] add custom hinge sensor support Ye Xiang
2020-12-15 5:44 ` [PATCH v4 1/3] HID: hid-sensor-custom: Add custom sensor iio support Ye Xiang
2021-01-04 9:45 ` Jiri Kosina
2020-12-15 5:44 ` [PATCH v4 2/3] iio: hid-sensors: Add hinge sensor driver Ye Xiang
2020-12-30 12:03 ` Jonathan Cameron
2020-12-15 5:44 ` [PATCH v4 3/3] iio:Documentation: Add documentation for hinge sensor channels Ye Xiang
2020-12-30 12:05 ` [PATCH v4 0/3] add custom hinge sensor support Jonathan Cameron
2020-12-31 2:46 ` Ye, Xiang [this message]
2021-01-09 18:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201231024640.GA5718@host \
--to=xiang.ye@intel.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).