From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BAF0C433E6 for ; Tue, 12 Jan 2021 03:29:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E48E122D6D for ; Tue, 12 Jan 2021 03:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727117AbhALD3M (ORCPT ); Mon, 11 Jan 2021 22:29:12 -0500 Received: from mail.v3.sk ([167.172.186.51]:36064 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726843AbhALD3M (ORCPT ); Mon, 11 Jan 2021 22:29:12 -0500 X-Greylist: delayed 479 seconds by postgrey-1.27 at vger.kernel.org; Mon, 11 Jan 2021 22:29:12 EST Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id A7BBADF242; Tue, 12 Jan 2021 03:16:46 +0000 (UTC) Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DIWAVnSiqYGb; Tue, 12 Jan 2021 03:16:45 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id BC4C0DF890; Tue, 12 Jan 2021 03:16:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at zimbra.v3.sk Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gWyR4YWaQsRt; Tue, 12 Jan 2021 03:16:44 +0000 (UTC) Received: from localhost (unknown [109.183.109.54]) by zimbra.v3.sk (Postfix) with ESMTPSA id 930C7DF242; Tue, 12 Jan 2021 03:16:43 +0000 (UTC) Date: Tue, 12 Jan 2021 04:20:28 +0100 From: Lubomir Rintel To: Dmitry Torokhov Cc: Souptick Joarder , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[] Message-ID: <20210112032028.GB1503339@demiurge.local> References: <1608581041-4354-1-git-send-email-jrdr.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Jan 04, 2021 at 02:02:13PM -0800, Dmitry Torokhov wrote: > On Tue, Dec 29, 2020 at 01:15:10PM +0530, Souptick Joarder wrote: > > On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder wrote: > > > > > > Kernel test robot throws below warning -> > > > > > > >> drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable > > > >> 'ariel_pwrbutton_id_table' [-Wunused-const-variable] > > > static const struct spi_device_id ariel_pwrbutton_id_table[] = { > > > ^ > > > 1 warning generated. > > > > > > Remove unused variable ariel_pwrbutton_id_table[] if no plan to use > > > it further. > > > > > > Reported-by: kernel test robot > > > Signed-off-by: Souptick Joarder > > > > Any comment on this patch ? > > Lubomir, would you prefer to remove the table or add it to the driver > structure as ariel_pwrbutton_driver->id_table? I believe it can be safely dropped, as the OF match seems to be sufficient. Thank you for the patch Souptick. Reviewed-by: Lubomir Rintel > > Thanks. > > -- > Dmitry