From: Linus Walleij <linus.walleij@linaro.org>
To: Ferruh Yigit <fery@cypress.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Javier Martinez Canillas <javier@dowhile0.org>
Cc: Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 5/7] Input: cyttsp - Drop the phys path
Date: Tue, 30 Mar 2021 10:54:22 +0200 [thread overview]
Message-ID: <20210330085424.2244653-6-linus.walleij@linaro.org> (raw)
In-Reply-To: <20210330085424.2244653-1-linus.walleij@linaro.org>
When I test to use the CY8CTMA340 with PostmarketOS I don't
have any problem whatsoever in dropping this phys path,
it finds and uses the touchscreen just as well. I suppose
it is because userspace is using modern input libraries.
I challenge the maintainers to point out a valid and still
used userspace that actually need this. I say we drop it.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/input/touchscreen/cyttsp_core.c | 2 --
drivers/input/touchscreen/cyttsp_core.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index 84f4f1c1a220..8ae9f00e5e31 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -655,10 +655,8 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
return ERR_PTR(error);
init_completion(&ts->bl_ready);
- snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(dev));
input_dev->name = "Cypress TTSP TouchScreen";
- input_dev->phys = ts->phys;
input_dev->id.bustype = bus_ops->bustype;
input_dev->dev.parent = ts->dev;
diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h
index c102a094e888..8eba9d8ba74a 100644
--- a/drivers/input/touchscreen/cyttsp_core.h
+++ b/drivers/input/touchscreen/cyttsp_core.h
@@ -115,7 +115,6 @@ struct cyttsp {
struct device *dev;
int irq;
struct input_dev *input;
- char phys[32];
const struct cyttsp_bus_ops *bus_ops;
struct cyttsp_bootloader_data bl_data;
struct cyttsp_sysinfo_data sysinfo_data;
--
2.29.2
next prev parent reply other threads:[~2021-03-30 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 8:54 [PATCH 0/7] Input: cyttsp - First round of modernizations Linus Walleij
2021-03-30 8:54 ` [PATCH 1/7] Input: cyttsp - Probe from compatibles Linus Walleij
2021-03-30 10:51 ` Javier Martinez Canillas
2021-03-30 8:54 ` [PATCH 2/7] Input: cyttsp - Obtain regulators Linus Walleij
2021-03-30 10:54 ` Javier Martinez Canillas
2021-03-30 8:54 ` [PATCH 3/7] Input: cyttsp - Error message on boot mode exit error Linus Walleij
2021-03-30 10:56 ` Javier Martinez Canillas
2021-03-30 8:54 ` [PATCH 4/7] Input: cyttsp - Reduce reset pulse timings Linus Walleij
2021-03-30 10:57 ` Javier Martinez Canillas
2021-03-30 8:54 ` Linus Walleij [this message]
2021-03-30 11:00 ` [PATCH 5/7] Input: cyttsp - Drop the phys path Javier Martinez Canillas
2021-03-30 8:54 ` [PATCH 6/7] Input: cyttsp - Set abs params for ABS_MT_TOUCH_MAJOR Linus Walleij
2021-03-30 11:00 ` Javier Martinez Canillas
2021-03-30 8:54 ` [PATCH 7/7] Input: cyttsp - Flag the device properly Linus Walleij
2021-03-30 11:01 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330085424.2244653-6-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fery@cypress.com \
--cc=javier@dowhile0.org \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).