From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: picolcd: remove unused variable
Date: Wed, 7 Apr 2021 18:28:09 +0200 [thread overview]
Message-ID: <20210407182809.135323e5@hemera.lan.sysophe.eu> (raw)
In-Reply-To: <1617777562-86341-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Hi Jiapeng,
This is a dupe of a fix already sent two weeks ago by Lee Jones.
see series "Rid W=1 warnings from HID".
@Benjamin: At first glance the patch will not break anything.
I've had no time though to check what
struct hid_device_id.raw_event
expects as return value to verify if we can just drop ret
or rather effectively should return something specific based
on it.
Bruno
On Wed, 7 Apr 2021 14:39:22 +0800 Jiapeng Chong wrote:
> Fix the following gcc warning:
>
> drivers/hid/hid-picolcd_core.c:332:6: warning: variable ‘ret’ set but
> not used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/hid/hid-picolcd_core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c
> index 1b5c632..682c2a2 100644
> --- a/drivers/hid/hid-picolcd_core.c
> +++ b/drivers/hid/hid-picolcd_core.c
> @@ -329,7 +329,6 @@ static int picolcd_raw_event(struct hid_device *hdev,
> {
> struct picolcd_data *data = hid_get_drvdata(hdev);
> unsigned long flags;
> - int ret = 0;
>
> if (!data)
> return 1;
> @@ -342,9 +341,9 @@ static int picolcd_raw_event(struct hid_device *hdev,
>
> if (report->id == REPORT_KEY_STATE) {
> if (data->input_keys)
> - ret = picolcd_raw_keypad(data, report, raw_data+1, size-1);
> + picolcd_raw_keypad(data, report, raw_data+1, size-1);
> } else if (report->id == REPORT_IR_DATA) {
> - ret = picolcd_raw_cir(data, report, raw_data+1, size-1);
> + picolcd_raw_cir(data, report, raw_data+1, size-1);
> } else {
> spin_lock_irqsave(&data->lock, flags);
> /*
prev parent reply other threads:[~2021-04-07 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 6:39 [PATCH] HID: picolcd: remove unused variable Jiapeng Chong
2021-04-07 16:28 ` Bruno Prémont [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407182809.135323e5@hemera.lan.sysophe.eu \
--to=bonbons@linux-vserver.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).