From: "José Expósito" <jose.exposito89@gmail.com>
To: jikos@kernel.org
Cc: benjamin.tissoires@redhat.com, spbnick@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stefanberzl@gmail.com, dlatypov@google.com,
kunit-dev@googlegroups.com
Subject: Re: [PATCH v3 0/4] Add support for XP-PEN Deco L
Date: Mon, 6 Jun 2022 12:12:37 +0200 [thread overview]
Message-ID: <20220606101237.GA939277@elementary> (raw)
In-Reply-To: <20220531181246.190729-1-jose.exposito89@gmail.com>
Hi,
On Tue, May 31, 2022 at 08:12:42PM +0200, José Expósito wrote:
> Hello everyone,
>
> This patchset adds support for the UGEE XP-PEN Deco L tablet.
> This device belongs to a family of tablets that must receive a chunk of
> magic data in order to be enabled (named UGEE v2 internally).
>
> [...]
>
> ---
>
> v1 - Initial version
> https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/
>
> v2 - Fix some errors reported by the kernel test robot:
>
> - Add MODULE_DESCRIPTION/LICENSE/AUTHOR to hid-uclogic-rdesc-test.c
> - Remove unused variable in uclogic_params_ugee_v2_init
> - Add sparse __force anotation in the result of cpu_to_le16
> - Add DISABLE_STRUCTLEAK_PLUGIN for KUnit tests
>
> https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/T/
>
> v3 - This version:
>
> - Improve Kconfig message
> - Add .kunitconfig. Thanks to Daniel Latypov for suggesting it in an
> unrelated patch:
> https://lore.kernel.org/dri-devel/CAGS_qxpV2SsihEdgXZ6+7N0dxLmdRANq+qE4iUZ2aNrf6vuLYg@mail.gmail.com/
As mentioned in the v3 changelog, I'm working on a DRM patch including
a few KUnit tests [1].
Some interesting highlights from the comments there:
- It looks like the maintainers prefer to include a single symbol [2]
to enable all tests in the subsystem.
Jiří, Benjamin, how would you like to handle it? Would you prefer to
have a symbol for each test (HID_UCLOGIC_KUNIT_TEST)? Or a symbol for
all tests (HID_KUNIT_TEST)?
- DISABLE_STRUCTLEAK_PLUGIN is not required [3]. I'd also need to
remove it here.
Jose
[1] https://lore.kernel.org/dri-devel/20220530102017.471865-1-jose.exposito89@gmail.com/T/
[2] https://lore.kernel.org/dri-devel/CABVgOSkCxu2xBnxwc6mO2AQaqzTbDf53PJzT2QvZNyLeumt5hg@mail.gmail.com/
[3] https://lore.kernel.org/dri-devel/CAGS_qxpFO4ixW=08ZcdcD9J1kU=B3mwoBJkPW8AKu0sKs8aKfA@mail.gmail.com/
next prev parent reply other threads:[~2022-06-06 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 18:12 [PATCH v3 0/4] Add support for XP-PEN Deco L José Expósito
2022-05-31 18:12 ` [PATCH v3 1/4] HID: uclogic: Make template placeholder IDs generic José Expósito
2022-05-31 18:12 ` [PATCH v3 2/4] HID: uclogic: Add KUnit tests for uclogic_rdesc_template_apply() José Expósito
2022-05-31 18:12 ` [PATCH v3 3/4] HID: uclogic: Allow to generate frame templates José Expósito
2022-05-31 18:12 ` [PATCH v3 4/4] HID: uclogic: Add support for XP-PEN Deco L José Expósito
2022-06-06 10:12 ` José Expósito [this message]
2022-06-08 9:51 ` [PATCH v3 0/4] " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606101237.GA939277@elementary \
--to=jose.exposito89@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dlatypov@google.com \
--cc=jikos@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spbnick@gmail.com \
--cc=stefanberzl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).