From: Matt Ranostay <matt.ranostay@konsulko.com>
To: jic23@kernel.org, gupt21@gmail.com,
benjamin.tissoires@redhat.com, jikos@kernel.org
Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-i2c@vger.kernel.org,
Matt Ranostay <matt.ranostay@konsulko.com>
Subject: [PATCH v5 2/5] iio: adc: stx104: fix future recursive dependencies
Date: Mon, 26 Sep 2022 19:50:47 -0700 [thread overview]
Message-ID: <20220927025050.13316-3-matt.ranostay@konsulko.com> (raw)
In-Reply-To: <20220927025050.13316-1-matt.ranostay@konsulko.com>
When using 'imply IIO' for other configurations which have 'select GPIOLIB'
the following recursive dependency is detected for STX1040
Switch from 'select GPIOLIB' to 'depends on GPIOLIB' to avoid this per
recommendation in kconfig-language.rst
drivers/gpio/Kconfig:14:error: recursive dependency detected!
drivers/gpio/Kconfig:14: symbol GPIOLIB is selected by STX104
drivers/iio/adc/Kconfig:20: symbol STX104 depends on IIO
drivers/iio/Kconfig:6: symbol IIO is implied by HID_MCP2221
drivers/hid/Kconfig:1227: symbol HID_MCP2221 depends on GPIOLIB
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
drivers/iio/adc/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 7fe5930891e0..929dd9493479 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1024,9 +1024,8 @@ config STMPE_ADC
config STX104
tristate "Apex Embedded Systems STX104 driver"
- depends on PC104 && X86
+ depends on PC104 && X86 && GPIOLIB
select ISA_BUS_API
- select GPIOLIB
help
Say yes here to build support for the Apex Embedded Systems STX104
integrated analog PC/104 card.
--
2.37.2
next prev parent reply other threads:[~2022-09-27 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 2:50 [PATCH v5 0/5] HID: mcp2221: iio support and device resource management Matt Ranostay
2022-09-27 2:50 ` [PATCH v5 1/5] i2c: muxes: ltc4306: fix future recursive dependencies Matt Ranostay
2022-09-29 13:48 ` Peter Rosin
2022-09-27 2:50 ` Matt Ranostay [this message]
2022-09-27 2:50 ` [PATCH v5 3/5] iio: dac: " Matt Ranostay
2022-09-27 2:50 ` [PATCH v5 4/5] HID: mcp2221: switch i2c registration to devm functions Matt Ranostay
2022-09-27 2:50 ` [PATCH v5 5/5] HID: mcp2221: add ADC/DAC support via iio subsystem Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927025050.13316-3-matt.ranostay@konsulko.com \
--to=matt.ranostay@konsulko.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gupt21@gmail.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).