From: Henry Castro <hcvcastro@gmail.com>
To: thunderbird2k@gmail.com
Cc: Henry Castro <hcvcastro@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] drivers: hid: adjust gyro calibration data
Date: Sun, 2 Oct 2022 18:03:01 -0400 [thread overview]
Message-ID: <20221002220301.18921-1-hcvcastro@gmail.com> (raw)
For some reason my DualShock 4 get the calibration
data values equal:
gyro_pitch_plus == gyro_pitch_minus
Probably due to some defect in the DS4 hardware, and cause
a CPU division exception to crash the linux kernel.
At least with the patch, I can continue play Retroarch
without using the Gyroscope :)
Signed-off-by: Henry Castro <hcvcastro@gmail.com>
---
drivers/hid/hid-sony.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 87b538656f64..656caa07b25f 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -1823,6 +1823,15 @@ static int dualshock4_get_calibration_data(struct sony_sc *sc)
acc_z_plus = get_unaligned_le16(&buf[31]);
acc_z_minus = get_unaligned_le16(&buf[33]);
+ if (gyro_pitch_plus == gyro_pitch_minus)
+ gyro_pitch_minus *= -1;
+
+ if (gyro_yaw_plus == gyro_yaw_minus)
+ gyro_yaw_minus *= -1;
+
+ if (gyro_roll_plus == gyro_roll_minus)
+ gyro_roll_minus *= -1;
+
/* Set gyroscope calibration and normalization parameters.
* Data values will be normalized to 1/DS4_GYRO_RES_PER_DEG_S degree/s.
*/
--
2.20.1
next reply other threads:[~2022-10-02 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 22:03 Henry Castro [this message]
2022-10-06 4:00 ` [PATCH 1/2] drivers: hid: adjust gyro calibration data Roderick Colenbrander
2022-10-06 13:36 ` Henry Castro
2022-10-06 14:03 ` Roderick Colenbrander
2022-10-06 18:31 ` Henry Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221002220301.18921-1-hcvcastro@gmail.com \
--to=hcvcastro@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thunderbird2k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).