From: Jean Delvare <jdelvare@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Daniel Hung-yu Wu <hywu@google.com>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Input: misc - atmel_captouch does not depend on OF
Date: Mon, 3 Oct 2022 17:29:53 +0200 [thread overview]
Message-ID: <20221003172953.30354439@endymion.delvare> (raw)
The atmel_captouch driver does not actually depend on OF, it includes
a non-OF device ID which could be used to instantiate the device, and
the driver code is already prepared to be built with or without OF. So
drop the unneeded dependency.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Daniel Hung-yu Wu <hywu@google.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
The problem I'm trying to solve here is that "depends on OF ||
COMPILE_TEST" does not make sense since OF can now be enabled on all
architectures. One way to fix this is by removing the dependency
altogether (this patch).
If the driver is known to be needed only on OF-enabled systems then we
could leave the dependency on OF and only drop COMPILE_TEST (and
simplify the driver code accordingly). I have an alternative patch
doing that already. Tell me what you prefer, I'm fine either way.
drivers/input/misc/Kconfig | 1 -
1 file changed, 1 deletion(-)
--- linux-5.19.orig/drivers/input/misc/Kconfig
+++ linux-5.19/drivers/input/misc/Kconfig
@@ -107,7 +107,6 @@ config INPUT_ATC260X_ONKEY
config INPUT_ATMEL_CAPTOUCH
tristate "Atmel Capacitive Touch Button Driver"
- depends on OF || COMPILE_TEST
depends on I2C
help
Say Y here if an Atmel Capacitive Touch Button device which
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2022-10-03 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 15:29 Jean Delvare [this message]
2022-10-04 3:54 ` [PATCH] Input: misc - atmel_captouch does not depend on OF Dmitry Torokhov
2022-10-04 5:44 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003172953.30354439@endymion.delvare \
--to=jdelvare@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=hywu@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).