From: Pietro Borrello <borrello@diag.uniroma1.it>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Hanno Zulla <kontakt@hanno.de>, Carlo Caione <carlo@endlessm.com>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Roderick Colenbrander <roderick.colenbrander@sony.com>,
Sven Eckelmann <sven@narfation.org>
Cc: linux-leds@vger.kernel.org,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>, Jakob Koschel <jkl820.git@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>,
Roderick Colenbrander <roderick@gaikai.com>,
Pietro Borrello <borrello@diag.uniroma1.it>
Subject: [PATCH 1/5] HID: bigben_remove: manually unregister leds
Date: Thu, 26 Jan 2023 00:24:53 +0000 [thread overview]
Message-ID: <20230125-hid-unregister-leds-v1-1-9a5192dcef16@diag.uniroma1.it> (raw)
In-Reply-To: <20230125-hid-unregister-leds-v1-0-9a5192dcef16@diag.uniroma1.it>
Unregister the LED controllers before device removal, as
bigben_set_led() may schedule bigben->worker after the structure has
been freed, causing a use-after-free.
Fixes: 4eb1b01de5b9 ("HID: hid-bigbenff: fix race condition for scheduled work during removal")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
---
drivers/hid/hid-bigbenff.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/hid/hid-bigbenff.c b/drivers/hid/hid-bigbenff.c
index e8b16665860d..d3201b755595 100644
--- a/drivers/hid/hid-bigbenff.c
+++ b/drivers/hid/hid-bigbenff.c
@@ -306,9 +306,14 @@ static enum led_brightness bigben_get_led(struct led_classdev *led)
static void bigben_remove(struct hid_device *hid)
{
+ int n;
struct bigben_device *bigben = hid_get_drvdata(hid);
bigben->removed = true;
+ for (n = 0; n < NUM_LEDS; n++) {
+ if (bigben->leds[n])
+ devm_led_classdev_unregister(&hid->dev, bigben->leds[n]);
+ }
cancel_work_sync(&bigben->worker);
hid_hw_stop(hid);
}
--
2.25.1
next prev parent reply other threads:[~2023-01-26 0:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:24 [PATCH 0/5] HID: manually unregister leds on device removal to prevent UAFs Pietro Borrello
2023-01-26 0:24 ` Pietro Borrello [this message]
2023-01-26 0:24 ` [PATCH 2/5] HID: asus_remove: manually unregister led Pietro Borrello
2023-01-26 0:24 ` [PATCH 3/5] HID: dualsense_remove: manually unregister leds Pietro Borrello
2023-01-26 0:43 ` Roderick Colenbrander
2023-01-26 0:47 ` Roderick Colenbrander
2023-01-26 12:09 ` [PATCH v2 " Pietro Borrello
2023-01-26 12:11 ` [PATCH v2 4/5] HID: dualshock4_remove: " Pietro Borrello
2023-01-26 1:01 ` [PATCH 3/5] HID: dualsense_remove: " Pietro Borrello
2023-01-26 0:24 ` [PATCH 4/5] HID: dualshock4_remove: " Pietro Borrello
2023-01-26 0:24 ` [PATCH 5/5] HID: sony_remove: " Pietro Borrello
2023-01-26 8:32 ` Sven Eckelmann
2023-05-10 10:12 ` [PATCH 0/5] HID: manually unregister leds on device removal to prevent UAFs Donald Buczek
2023-05-10 10:59 ` Benjamin Tissoires
2023-05-10 11:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125-hid-unregister-leds-v1-1-9a5192dcef16@diag.uniroma1.it \
--to=borrello@diag.uniroma1.it \
--cc=benjamin.tissoires@redhat.com \
--cc=c.giuffrida@vu.nl \
--cc=carlo@endlessm.com \
--cc=h.j.bos@vu.nl \
--cc=jikos@kernel.org \
--cc=jkl820.git@gmail.com \
--cc=jkosina@suse.cz \
--cc=kontakt@hanno.de \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).