linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: msizanoen <msizanoen@qtmlabs.xyz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	stable@vger.kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: alps: fix compatibility with -funsigned-char
Date: Sun, 19 Mar 2023 17:54:32 +0100	[thread overview]
Message-ID: <20230319165432.5dj3stwgz4aoluf2@pali> (raw)
In-Reply-To: <1fd818c2-4e68-8760-9123-de4fa1920c6b@qtmlabs.xyz>

On Sunday 19 March 2023 16:56:11 msizanoen wrote:
> Patch confirmed working as expected on real hardware.
> 
> Tested-by: msizanoen <msizanoen@qtmlabs.xyz>

Thank you for testing. Patch looks good, you can add my:

Reviewed-by: Pali Rohár <pali@kernel.org>

Anyway, for future, what do you think about using of s8 and u8 types?
It could prevent this signdness char nightmare.

> On 3/18/23 21:42, msizanoen wrote:
> > The AlpsPS/2 code previously relied on the assumption that `char` is a
> > signed type, which was true on x86 platforms (the only place where this
> > driver is used) before kernel 6.2. However, on 6.2 and later, this
> > assumption is broken due to the introduction of -funsigned-char as a new
> > global compiler flag.
> > 
> > Fix this by explicitly specifying the signedness of `char` when sign
> > extending the values received from the device.
> > 
> > Fixes: f3f33c677699 ("Input: alps - Rushmore and v7 resolution support")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: msizanoen <msizanoen@qtmlabs.xyz>
> > ---
> >   drivers/input/mouse/alps.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> > index 989228b5a0a4..1c570d373b30 100644
> > --- a/drivers/input/mouse/alps.c
> > +++ b/drivers/input/mouse/alps.c
> > @@ -2294,20 +2294,20 @@ static int alps_get_v3_v7_resolution(struct psmouse *psmouse, int reg_pitch)
> >   	if (reg < 0)
> >   		return reg;
> > -	x_pitch = (char)(reg << 4) >> 4; /* sign extend lower 4 bits */
> > +	x_pitch = (signed char)(reg << 4) >> 4; /* sign extend lower 4 bits */
> >   	x_pitch = 50 + 2 * x_pitch; /* In 0.1 mm units */
> > -	y_pitch = (char)reg >> 4; /* sign extend upper 4 bits */
> > +	y_pitch = (signed char)reg >> 4; /* sign extend upper 4 bits */
> >   	y_pitch = 36 + 2 * y_pitch; /* In 0.1 mm units */
> >   	reg = alps_command_mode_read_reg(psmouse, reg_pitch + 1);
> >   	if (reg < 0)
> >   		return reg;
> > -	x_electrode = (char)(reg << 4) >> 4; /* sign extend lower 4 bits */
> > +	x_electrode = (signed char)(reg << 4) >> 4; /* sign extend lower 4 bits */
> >   	x_electrode = 17 + x_electrode;
> > -	y_electrode = (char)reg >> 4; /* sign extend upper 4 bits */
> > +	y_electrode = (signed char)reg >> 4; /* sign extend upper 4 bits */
> >   	y_electrode = 13 + y_electrode;
> >   	x_phys = x_pitch * (x_electrode - 1); /* In 0.1 mm units */

  reply	other threads:[~2023-03-19 16:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18 14:42 [PATCH] input: alps: fix compatibility with -funsigned-char msizanoen
2023-03-18 16:25 ` Hans de Goede
2023-03-19  9:56 ` msizanoen
2023-03-19 16:54   ` Pali Rohár [this message]
2023-03-19 17:45 ` Jason A. Donenfeld
2023-03-19 19:43   ` Pali Rohár
2023-03-20  0:17 ` [PATCH v2] " msizanoen
2023-03-20  4:43   ` Dmitry Torokhov
2023-03-20  4:52 ` [PATCH v3] " msizanoen1
2023-03-20  6:03   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230319165432.5dj3stwgz4aoluf2@pali \
    --to=pali@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msizanoen@qtmlabs.xyz \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).