From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B7CC761A6 for ; Mon, 20 Mar 2023 00:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbjCTA6j (ORCPT ); Sun, 19 Mar 2023 20:58:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbjCTA5r (ORCPT ); Sun, 19 Mar 2023 20:57:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D4B9D51F; Sun, 19 Mar 2023 17:55:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6EA3661122; Mon, 20 Mar 2023 00:55:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37275C433EF; Mon, 20 Mar 2023 00:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679273726; bh=P4CzGikgM7jVUFgJYP7iZJQTknwuEyOTArmUon2XDVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q33cvbxhxYiN9LBBWkG0PkUMPa6q7/R0gSkfk8B3z54XqlvGJZQlFiDz5Yc2zn8s1 CaWRd2S8so1JPK9DHOmQz/D01j+rb5hiWX9RJnl27TDaExz5Oz4/Lnyejzh+qyack5 g8CBUmT5LSzGExK9PfQmIjBVJdToldy7NTH1eABpmeRnWkpcTgwSUsN9gy1ExbLkaJ UT2rOb1TqwG+dU3Fsl5NvM3/tkkbOdvfNqyddLnx3Df1pT8zat6nz26Qq/mSeD1q/r sOWCop5Bb+2oH15DwrFCxXIxCAAm2alvfy+c9HhDfPEkVTXrhVh+7zdBzF0tglPgHt TISlV31WhP2Fw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Danny Kaehn , Benjamin Tissoires , Sasha Levin , jikos@kernel.org, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 03/17] HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded Date: Sun, 19 Mar 2023 20:55:05 -0400 Message-Id: <20230320005521.1428820-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320005521.1428820-1-sashal@kernel.org> References: <20230320005521.1428820-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Danny Kaehn [ Upstream commit 37f5b858a66543b2b67c0288280af623985abc29 ] The CP2112 generates interrupts from a polling routine on a thread, and can only support threaded interrupts. This patch configures the gpiochip irq chip with this flag, disallowing consumers to request a hard IRQ from this driver, which resulted in a segfault previously. Signed-off-by: Danny Kaehn Link: https://lore.kernel.org/r/20230210170044.11835-1-kaehndan@gmail.com Signed-off-by: Benjamin Tissoires Signed-off-by: Sasha Levin --- drivers/hid/hid-cp2112.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 172f20e88c6c9..d902fe43cb818 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -1352,6 +1352,7 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) girq->parents = NULL; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_simple_irq; + girq->threaded = true; ret = gpiochip_add_data(&dev->gc, dev); if (ret < 0) { -- 2.39.2