From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E21C433DB for ; Tue, 23 Mar 2021 14:03:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5D2B619B9 for ; Tue, 23 Mar 2021 14:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232057AbhCWOCf (ORCPT ); Tue, 23 Mar 2021 10:02:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23562 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232156AbhCWOCH (ORCPT ); Tue, 23 Mar 2021 10:02:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616508126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h9t+B72idifaoxcXCo+oMvX5GZKbGC3CJn59xHhYgqM=; b=McKYPLH4zcUwTp0s14NGzvavByZRHU5ci//QIJ386OV+Ib8xA2jRj/PmfHKzBRDfup69sl 4rJHkJOXhZQVMfBdtFIlSIvbYQLJgv6d3AhjIqRRpVfOirodcxvbFCmwuZusGXXpv/QAmb BtYenr8HDcvohqf651UnuV/fBfVamBg= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-B_JaWJNANgGx0LDyZAP1sg-1; Tue, 23 Mar 2021 10:02:04 -0400 X-MC-Unique: B_JaWJNANgGx0LDyZAP1sg-1 Received: by mail-ed1-f69.google.com with SMTP id i6so1003674edq.12 for ; Tue, 23 Mar 2021 07:02:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h9t+B72idifaoxcXCo+oMvX5GZKbGC3CJn59xHhYgqM=; b=G3HTrL2zIS1cFtFOatW700186Ucy/hYlgcT219a7CudnAU4Wa/CRiaLfLhyLpsQtAN FsgjhA4oBLYnkaC8lBeANOvjB2zU7GzUqAdY/WxBtthdQ8qFUPx7c4D94Pdw7dPtu86b uwOWX+Kh+0On59YE4zEJpP4K8aUYomipv1+/oABq1jWtE3voQIrI6zdT54/xfDEjwdo3 zrsKceY0es3hq9NnoXG8JUzUd20iP2a4qg9iRtT5W1u1pvsruCZQIky5y11jQZMCd/14 La8+kKESj5h8QmYyVsRIke3FirYjIxlcxGMb4A2LPjaEZTQU+ZAYI7T7MgfEUW2+TSZ/ zH2g== X-Gm-Message-State: AOAM532X4LfhW2ELmg4aZ6CK3W5oY7KDJusmtLRaJ6KS15Qdn/+WGaLd 6PASsO8jZygaIO98UlTqVT/O7YiJi8dTieS/fuf8I3dJu3mx93xwJgwppuM/IFpsvA8gOXvIr7E 7HPCESBgwtpCYZjCNhk7valQ= X-Received: by 2002:aa7:d347:: with SMTP id m7mr4645705edr.260.1616508123442; Tue, 23 Mar 2021 07:02:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/jft58be+yd3ok4y/L/nD5g6FSNmyDUPbETZNr8e9+wQE9nCWmFOaK5jHOD25g4xPWGD9ig== X-Received: by 2002:aa7:d347:: with SMTP id m7mr4645687edr.260.1616508123288; Tue, 23 Mar 2021 07:02:03 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id y24sm13081882eds.23.2021.03.23.07.02.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 07:02:02 -0700 (PDT) Subject: Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry To: Arnd Bergmann , Dmitry Torokhov , Marcos Paulo de Souza Cc: Arnd Bergmann , Po-Hsu Lin , Kevin Locke , Alexey Dobriyan , David Pedersen , Rajat Jain , Chris Chiu , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210323130623.2302402-1-arnd@kernel.org> From: Hans de Goede Message-ID: <2187f843-f475-6d95-819a-ebb875b25d44@redhat.com> Date: Tue, 23 Mar 2021 15:02:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210323130623.2302402-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 3/23/21 2:06 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The Zenbook Flip entry that was added overwrites a previous one > because of a typo: > > In file included from drivers/input/serio/i8042.h:23, > from drivers/input/serio/i8042.c:131: > drivers/input/serio/i8042-x86ia64io.h:591:28: error: initialized field overwritten [-Werror=override-init] > 591 | .matches = { > | ^ > drivers/input/serio/i8042-x86ia64io.h:591:28: note: (near initialization for 'i8042_dmi_noselftest_table[0].matches') > > Add the missing separator between the two. > > Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to noselftest list") > Signed-off-by: Arnd Bergmann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/input/serio/i8042-x86ia64io.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h > index 9119e12a5778..a5a003553646 100644 > --- a/drivers/input/serio/i8042-x86ia64io.h > +++ b/drivers/input/serio/i8042-x86ia64io.h > @@ -588,6 +588,7 @@ static const struct dmi_system_id i8042_dmi_noselftest_table[] = { > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /* Notebook */ > }, > + }, { > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /* Convertible Notebook */ >