From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BC7C433DB for ; Mon, 8 Mar 2021 16:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CBB06521D for ; Mon, 8 Mar 2021 16:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbhCHQEL (ORCPT ); Mon, 8 Mar 2021 11:04:11 -0500 Received: from mga14.intel.com ([192.55.52.115]:16665 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbhCHQEE (ORCPT ); Mon, 8 Mar 2021 11:04:04 -0500 IronPort-SDR: AnMju5dDiFZXcLyIPB/Y7tMn/8OTRnMtADhh6yBu1ynM+SqBI8hoGdeBgQbIB3Iz1S0JCy4Qiz sd5UrQ9BVbyw== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="187417777" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="187417777" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:04:03 -0800 IronPort-SDR: oArg1YrvPkI/vKbk+xDakXU2Chg+VproKHC99GVZyEv8tK9wp+Rs+d1CKXUVeDrF2vkrBA1aBL HAMj/zUlf68Q== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="385895120" Received: from arohrbax-mobl.amr.corp.intel.com ([10.209.91.130]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:03:49 -0800 Message-ID: <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com> Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition From: Srinivas Pandruvada To: Jiri Kosina , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Benjamin Tissoires , Enric Balletbo i Serra , Guenter Roeck , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 08 Mar 2021 08:03:49 -0800 In-Reply-To: References: <20210206151348.14530-1-uwe@kleine-koenig.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, 2021-03-08 at 11:07 +0100, Jiri Kosina wrote: > On Sat, 6 Feb 2021, Uwe Kleine-König wrote: > > > A remove callback is only ever called for a bound device. So there > > is no > > need to check for device or driver being NULL. > > Srinivas, any objections to this patchset? The cleanups look good to > me. Sorry, I missed this series. No objection for taking these patches. Thanks, Srinivas > Thanks, >