From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BEDC33C9E for ; Wed, 15 Jan 2020 02:58:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE23B24673 for ; Wed, 15 Jan 2020 02:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728894AbgAOC6q (ORCPT ); Tue, 14 Jan 2020 21:58:46 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:49052 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728883AbgAOC6q (ORCPT ); Tue, 14 Jan 2020 21:58:46 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 25934B7FB7549D8DC35F; Wed, 15 Jan 2020 10:58:43 +0800 (CST) Received: from [127.0.0.1] (10.133.215.186) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Wed, 15 Jan 2020 10:58:39 +0800 Subject: Re: [PATCH 1/1] HID: hiddev: remove a duplicated check To: Jiri Kosina CC: Benjamin Tissoires , linux-usb , linux-input , "Hillf Danton" References: <20191224035117.98816-1-thunder.leizhen@huawei.com> <50fd522f-e276-420c-3c6a-0f193bc16ca2@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <358ce05d-a01b-fa54-802c-995724d506f6@huawei.com> Date: Wed, 15 Jan 2020 10:58:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.215.186] X-CFilter-Loop: Reflected Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 2020/1/14 22:19, Jiri Kosina wrote: > On Tue, 14 Jan 2020, Leizhen (ThunderTown) wrote: > >> Does no one pay attention to this problem? Although there is no >> functional problem, but it seems confusing. >> >> if (!list->hiddev->exist) { <--------- >> res = -ENODEV; | >> goto bail_unlock; | >> } | >> if (!list->hiddev->open++) | >> if (list->hiddev->exist) { <--------- //It's always true. > > This code no longer exists after refactoring that happened in commit > 18a1b06e5b91d47. OK >