From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaya Kumar Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others) Date: Tue, 5 Jan 2010 07:57:44 +0800 Message-ID: <45a44e481001041557t1f87f8d4i959abbbee0c4346@mail.gmail.com> References: <200912142122.nBELMW7d001243@mustang.cs.nmsu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-iw0-f194.google.com ([209.85.223.194]:48517 "EHLO mail-iw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753422Ab0AEAF0 convert rfc822-to-8bit (ORCPT ); Mon, 4 Jan 2010 19:05:26 -0500 In-Reply-To: <200912142122.nBELMW7d001243@mustang.cs.nmsu.edu> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Rick L. Vinyard Jr." Cc: linux-kernel@vger.kernel.org, krzysztof.h1@wp.pl, akpm@linux-foundation.org, linux-usb@vger.kernel.org, oliver@neukum.org, linux-input@vger.kernel.org, jkosina@suse.cz On Tue, Dec 15, 2009 at 5:22 AM, Rick L. Vinyard Jr. wrote: > Additionally, this device contains a 160x43 monochrome LCD display. > A registered framebuffer device manages this display. The design > of this portion of the driver was based on the design of the > hecubafb driver with deferred framebuffer I/O since there is > no real memory to map. Hi Rick, Interesting work. I recommend CCing linux-fbdev@vger.kernel.org too since it contains a fbdev interface. > +config LOGITECH_G13 > + =A0 =A0 =A0 tristate "Logitech G13 gameboard support" > + =A0 =A0 =A0 depends on HID_LOGITECH > + =A0 =A0 =A0 depends on FB > + =A0 =A0 =A0 select FB_SYS_FILLRECT > + =A0 =A0 =A0 select FB_SYS_COPYAREA > + =A0 =A0 =A0 select FB_SYS_IMAGEBLIT > + =A0 =A0 =A0 select FB_SYS_FOPS Does this need to select FB_DEFERRED_IO? > --- /dev/null > +++ b/drivers/hid/hid-g13-logo.xbm > @@ -0,0 +1,75 @@ > +#define g13_lcd_width 160 > +#define g13_lcd_height 43 > +static unsigned char g13_lcd_bits[] =3D { > + =A0 0x00, 0x00, 0x07, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x0= 0, 0x00, Was there a reason for having a new logo file? If so, you might want to put it in the comments and also put it together with the standard kernel logo. > +/* 160*43 rounded to nearest whole byte which is 160*48 since bytes = are > + =A0 vertical the y component must be a multiple of 8 */ > +#define G13FB_SIZE (160*48/8) Minor nit, I think there is a macro for this, DIV_ROUND_UP, or maybe this could be better done in the function that uses this value. > +static ssize_t g13_set_mled(struct hid_device *hdev, unsigned mled); Does this need to be here or can the code be reordered? > +static struct fb_var_screeninfo g13fb_var =3D { > + =A0 =A0 =A0 .xres =3D G13FB_WIDTH, > + =A0 =A0 =A0 .yres =3D G13FB_HEIGHT, > + =A0 =A0 =A0 .xres_virtual =3D G13FB_WIDTH, > + =A0 =A0 =A0 .yres_virtual =3D G13FB_HEIGHT, > + =A0 =A0 =A0 .bits_per_pixel =3D 1, > + =A0 =A0 =A0 .nonstd =3D 1, > +}; I think the nonstd is a bug. Yes, hecubafb and metronomefb seem to have the same bug as well. nonstd is used if you want something like =46B_NONSTD_HAM or FB_NONSTD_REV_PIX_IN_B, which I don't think is what you want. Hope this helps. Best regards, jaya -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html