linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Ebke <johannes.ebke@physik.uni-muenchen.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: Linux Force Feedback for Saitek Cyborg Evo Force
Date: Fri, 18 Dec 2009 09:59:42 +0100	[thread overview]
Message-ID: <4B2B447E.80808@physik.uni-muenchen.de> (raw)
In-Reply-To: <4B2ABC62.2030600@physik.uni-muenchen.de>

Hi,

...it worked in the jscalibrator, but in the game I noticed that the
axis ranges (as given by the HID driver, which also works for non-ff
mode) are different to the iforce ones:
x/y is from 0 (top, left, rudder left) to 4096 (bottom right) or 255
(rudder right), and throttle is from 255 (no throttle) to 0 (full)

In iforce the x-range is from -1920 to 1920, so 256 steps less than the
saitek range...
This is a bit more difficult to fit into the driver framework, because
the ranges are set in the initialization routine in iforce-main.c.
I'll put an if() in there for starters.

Cheers,
Johannes


Johannes Ebke wrote:
> Hi Jiri,
> 
> I have looked into the problems some more, and have found that the cause
> of the crash was a change I made because I misunderstood the code
> (LO(cmd) is the number of bytes in in the message, and is not
> transferred on USB - i had removed it from the message...)
> 
> First, the changes in the normal input, the joystick axis+buttons message:
> * Prefix is 0x06 instead of 0x01 (joystick) or 0x03 (gamepad)
> * Throttle is not inverted (data[4] instead of 255-data[4])
> * Rudder is present and unsigned (not signed, as in iforce)
> 
> I have attached a patch that I think fixes this (it works for me :)
> Since saitek uses a different protocol byte, this can be done without
> adding per-device flags to the driver.
> 
> It also adds a button map btn_saitek_cyborg that switches button 1&2 to
> make the button number the same as printed on the device, and
> abs_saitek_cyborg for a joystick with rudder but only one hat.
> 
> The fftest effects seem to work, but some are feeble and feel strange -
> I suspect there are some subtle changes, for example I am quite sure
> that the Saitek uses signed (twos complement) numbers for effect
> strength (this could perhaps explain the 'strange' behavior for 0x80
> byte values in the current code)...
> 
> Cheers,
> Johannes
> 
> 
> Jiri Kosina wrote:
>> On Mon, 14 Dec 2009, Johannes Ebke wrote:
>>
>>> I own a Saitek Cyborg Evo Force which works fine with the HID driver on
>>> Linux. However, i could not find a force feedback driver for it, and
>>> just adding the USB id and spec to the IForce driver does not work (and
>>> crashes the kernel)
>> Hi Johannes,
>>
>> thanks for your e-mail. I hope you don't mind adding a few relevant CCs.
>>
>> First, kernel crashing means that we are probably lacking some error 
>> handling in the iforce driver, which we should add if possible. Could you 
>> please post the oops message preceeding the crash?
>>
>>> After that, I have reverse-engineered the protocol using usb snoops from 
>>> a kvm virtual machine with XP on it. Using libusb, I have verified that 
>>> I understand the protocol, and it actually looks quite similar to the 
>>> iforce protocol (no wonder, it just implements the DirectInput interface 
>>> in hardware)
>> Good job, thanks a lot for doing this.
>>
>>> My question: Would it make sense to adapt the iforce modules to include 
>>> this slightly modified protocol (other initialization strings, other 
>>> magic bytes) or would it be better to copy & modify?
>> It really depends how much different the protocols really are. iforce 
>> driver currently doesn't support any per-device flags which would allow 
>> for introducing slight differences between individual models.
>>
>> Maybe it would help if you could just summarize the most important 
>> differences to iforce protocol, so that we could see what aproach would be 
>> the best.
>>
>> Thanks,
>>

  reply	other threads:[~2009-12-18  8:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4B26B824.8010403@physik.uni-muenchen.de>
2009-12-15 13:07 ` Linux Force Feedback for Saitek Cyborg Evo Force Jiri Kosina
2009-12-17 23:18   ` Johannes Ebke
2009-12-18  8:59     ` Johannes Ebke [this message]
2009-12-18 10:52     ` Jiri Kosina
2009-12-18 17:50       ` Dmitry Torokhov
2009-12-19 23:36         ` Johannes Ebke
2009-12-21  0:22           ` Melchior FRANZ
2009-12-21  7:44           ` Dmitry Torokhov
2009-12-21  7:59             ` Dmitry Torokhov
2009-12-21  8:22             ` Dmitry Torokhov
2009-12-29 12:46               ` Johannes Ebke
2009-12-29 22:40                 ` Dmitry Torokhov
2009-12-30  3:23                   ` Dmitry Torokhov
2009-12-30  9:01                     ` Johannes Ebke
2009-12-30 10:47                       ` Dmitry Torokhov
2009-12-30 11:32                         ` Johannes Ebke
2011-06-08 18:51                           ` Richie Ward
2009-12-21 11:45             ` [PATCH] " Johannes Ebke
2009-12-21  0:24 Melchior FRANZ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2B447E.80808@physik.uni-muenchen.de \
    --to=johannes.ebke@physik.uni-muenchen.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).