From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Rob Herring <robh@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, Stefan Wahren <wahrenst@gmx.net>,
Ray Jui <rjui@broadcom.com>,
u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org,
Eric Anholt <eric@anholt.net>,
dmitry.torokhov@gmail.com, Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com, p.zabel@pengutronix.de,
linux-rpi-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
linux-input@vger.kernel.org, devel@driverdev.osuosl.org,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
bgolaszewski@baylibre.com, sboyd@kernel.org,
linux-gpio@vger.kernel.org, Scott Branden <sbranden@broadcom.com>,
linus.walleij@linaro.org, linux-clk@vger.kernel.org,
andy.shevchenko@gmail.com
Subject: Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus
Date: Wed, 04 Nov 2020 20:55:19 +0100 [thread overview]
Message-ID: <4debc77f5c72e1f4eff36a700231493bf9fbf404.camel@suse.de> (raw)
In-Reply-To: <20201104190612.GA3959462@bogus>
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
On Wed, 2020-11-04 at 13:06 -0600, Rob Herring wrote:
> On Wed, 04 Nov 2020 11:39:35 +0100, Nicolas Saenz Julienne wrote:
> > The PWM bus controlling the fan in RPi's official PoE hat can only be
> > controlled by the board's co-processor.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > - Update bindings to use 2 #pwm-cells
> >
> > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 +++++++++++++++++++
> > .../pwm/raspberrypi,firmware-pwm.h | 13 ++++++++++++
> > 2 files changed, 33 insertions(+)
> > create mode 100644 include/dt-bindings/pwm/raspberrypi,firmware-pwm.h
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: pwm:#pwm-cells:0:0: 2 was expected
Yes I forgot to update the example...
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-04 19:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:39 [PATCH v3 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() Nicolas Saenz Julienne
2020-11-05 9:13 ` Bartosz Golaszewski
2020-11-05 9:28 ` Nicolas Saenz Julienne
2020-11-05 9:42 ` Bartosz Golaszewski
2020-11-10 13:38 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 02/11] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 03/11] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2020-11-05 9:08 ` Bartosz Golaszewski
2020-11-04 10:39 ` [PATCH v3 04/11] reset: raspberrypi: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 05/11] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 06/11] staging: vchiq: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2020-11-12 1:45 ` Dmitry Torokhov
2020-11-12 9:06 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 08/11] firmware: raspberrypi: Get rid of rpi_firmware_get() Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2020-11-04 19:06 ` Rob Herring
2020-11-04 19:55 ` Nicolas Saenz Julienne [this message]
2020-11-04 10:39 ` [PATCH v3 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 11/11] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4debc77f5c72e1f4eff36a700231493bf9fbf404.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).