RE: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function

From: "joewu(吳仲振)" <joewu@msi.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Joe Wu <joewu@msi.corp-partner.google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Furquan Shaikh <furquan@chromium.org>,
	Daisuke Nojiri <dnojiri@chromium.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	Benson Leung <bleung@chromium.org>,
	Derek Huang <derekhuang@google.com>,
	"Dustin L . Howett" <dustin@howett.net>,
	Guenter Roeck <groeck@chromium.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Xiang wangx <wangxiang@cdjrlc.com>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	Prashant Malani <pmalani@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	"chrome-platform@lists.linux.dev"
	<chrome-platform@lists.linux.dev>,
	"Stephen Boyd" <swboyd@chromium.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Tinghan Shen <tinghan.shen@mediatek.com>
Subject: RE: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function
Date: Thu, 22 Dec 2022 06:34:59 +0000	[thread overview]
Message-ID: <5600a6d36a944f0e968e4935ffac8430@msi.com> (raw)
In-Reply-To: <Y6P0Ogh1T6n5i3Bi@kroah.com>

Hi Greg,

I'll fix it. Thanks.

-----Original Message-----
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Sent: Thursday, December 22, 2022 2:08 PM
To: Joe Wu <joewu@msi.corp-partner.google.com>
Cc: LKML <linux-kernel@vger.kernel.org>; Furquan Shaikh <furquan@chromium.org>; Daisuke Nojiri <dnojiri@chromium.org>; Dmitry Torokhov <dmitry.torokhov@gmail.com>; Benson Leung <bleung@chromium.org>; Derek Huang <derekhuang@google.com>; Dustin L . Howett <dustin@howett.net>; joewu(吳仲振) <joewu@msi.com>; Guenter Roeck <groeck@chromium.org>; linux-input@vger.kernel.org; Xiang wangx <wangxiang@cdjrlc.com>; Gustavo A . R . Silva <gustavoars@kernel.org>; Prashant Malani <pmalani@chromium.org>; Douglas Anderson <dianders@chromium.org>; Tzung-Bi Shih <tzungbi@kernel.org>; chrome-platform@lists.linux.dev; Stephen Boyd <swboyd@chromium.org>; Jonathan Cameron <Jonathan.Cameron@huawei.com>; Sebastian Reichel <sebastian.reichel@collabora.com>; Tinghan Shen <tinghan.shen@mediatek.com>
Subject: Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function

On Thu, Dec 22, 2022 at 10:15:42AM +0800, Joe Wu wrote:
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -3471,6 +3471,9 @@ struct ec_response_get_next_event_v1 {
>  #define EC_MKBP_VOL_UP		1
>  #define EC_MKBP_VOL_DOWN	2
>  #define EC_MKBP_RECOVERY	3
> +#define EC_MKBP_BRI_UP          4
> +#define EC_MKBP_BRI_DOWN        5
> +#define EC_MKBP_SCREEN_LOCK     6

You forgot to use tabs :(

*****CONFIDENTIAL INFORMATION*****

This email is intended only for the use of the person or entity to whom it is
addressed and contains information that may be subject to and/or may be
restricted from disclosure by contract or applicable law. If you are not the 
intended recipient of this email, be advised that any disclosure, copy, 
distribution or use of the contents of this message is strictly prohibited. 
If you are not the intended recipient of this email, please notify the sender 
that you have received this in error by replying to this message. Then, 
please delete it from your system. Our Privacy Policy is available here 
https://www.msi.com/page/privacy-policy. Thank you.