Linux Input Archive on lore.kernel.org
 help / color / Atom feed
From: Merlijn Wajer <merlijn@wizzup.org>
To: linux-omap@vger.kernel.org
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Darren Hart (VMware)" <dvhart@infradead.org>,
	"Mattias Jacobsson" <2pi@mok.nu>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 0/2] Add SW_MACHINE_COVER key
Date: Tue, 9 Jun 2020 01:56:02 +0200
Message-ID: <60f55d93-e7d3-15e7-3b34-00e3e3eda99c@wizzup.org> (raw)
In-Reply-To: <b13b6bf3-f9e3-1151-81f9-53f3ec9dc26a@wizzup.org>

[-- Attachment #1.1: Type: text/plain, Size: 1633 bytes --]

Hi,

A while later (again) - any thoughts/comments?

Should I resend the series?

Thanks,
Merlijn

On 15/04/2020 15:29, Merlijn Wajer wrote:
> Hi,
> 
> Any objections or further comments on these two patches? It's been a while.
> 
> Cheers,
> Merlijn
> 
> On 15/02/2020 18:02, Merlijn Wajer wrote:
>> this series adds the sw_machine_cover key, and changes the nokia n900 dts to
>> expose the key via gpio-keys.
>>
>> before, this gpio was used as card detect gpio, causing the card not to show up
>> if the phone was booted without cover, see this thread on linux-omap:
>>
>>     n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18)
>>
>> since there is no realistic use for using this gpio as card detect, instead
>> expose it to userspace via gpio-keys. there are no event type for machine covers
>> yet, so add that first.
>>
>> the key should be 1 when the cover is closed, and 0 when the cover is open.
>>
>> starting the nokia n900 with the cover removed, putting the cover in place:
>>
>>     event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1
>>
>> removing the cover again, exposing mmc1 and the battery:
>>
>>     event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0
>>
>> Merlijn Wajer (2):
>>   Input: add `SW_MACHINE_COVER`
>>   ARM: dts: n900: remove mmc1 card detect gpio
>>
>>  arch/arm/boot/dts/omap3-n900.dts       | 12 ++++++++----
>>  include/linux/mod_devicetable.h        |  2 +-
>>  include/uapi/linux/input-event-codes.h |  3 ++-
>>  3 files changed, 11 insertions(+), 6 deletions(-)
>>
> 
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15 17:02 Merlijn Wajer
2020-02-15 17:02 ` [PATCH 1/2] Input: add `SW_MACHINE_COVER` Merlijn Wajer
2020-02-15 17:02 ` [PATCH 2/2] ARM: dts: n900: remove mmc1 card detect gpio Merlijn Wajer
2020-02-25 14:31 ` [PATCH 0/2] Add SW_MACHINE_COVER key Tony Lindgren
2020-04-15 13:29 ` Merlijn Wajer
2020-06-08 23:56   ` Merlijn Wajer [this message]
2020-06-09 11:21     ` Pavel Machek
2020-06-12 12:53 Merlijn Wajer
2020-06-16 10:50 ` Pavel Machek
2020-06-30 19:29 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60f55d93-e7d3-15e7-3b34-00e3e3eda99c@wizzup.org \
    --to=merlijn@wizzup.org \
    --cc=2pi@mok.nu \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git