From: Dmitry Osipenko <digetx@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jiada Wang <jiada_wang@mentor.com>
Cc: "nick@shmanahar.org" <nick@shmanahar.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Andrew_Gabbasov@mentor.com" <Andrew_Gabbasov@mentor.com>,
"erosca@de.adit-jv.com" <erosca@de.adit-jv.com>
Subject: Re: [PATCH v2 1/1] Input: atmel_mxt_ts - implement I2C retries
Date: Sat, 5 Sep 2020 21:57:08 +0300 [thread overview]
Message-ID: <610b2513-7d62-386d-ed2a-54e1bea4df43@gmail.com> (raw)
In-Reply-To: <CAHp75Vfw1bJ+0pRJKVJ=nCJ-5rVzYLjkP4iWPqiG-it0qp5GFg@mail.gmail.com>
05.09.2020 21:02, Andy Shevchenko пишет:
...
> #define MXT_CRC_TIMEOUT 1000 /* msec */
> #define MXT_FW_RESET_TIME 3000 /* msec */
> #define MXT_FW_CHG_TIMEOUT 300 /* msec */
> +#define MXT_WAKEUP_TIME 25 /* msec */
>
>
> Can we simple add _MS unit suffix to the definition?
I'd expect this
> /* Command to unlock bootloader */
> #define MXT_UNLOCK_CMD_MSB 0xaa
> @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client,
> struct i2c_msg xfer[2];
> u8 buf[2];
> int ret;
> + bool retry = false;
>
>
> Keep this ordered by length.
and this to be separate patches that are cleaning whole driver code,
otherwise there are no much benefits.
next prev parent reply other threads:[~2020-09-05 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 15:59 [PATCH v2 1/1] Input: atmel_mxt_ts - implement I2C retries Jiada Wang
2020-09-05 14:06 ` Dmitry Osipenko
[not found] ` <CAHp75Vfw1bJ+0pRJKVJ=nCJ-5rVzYLjkP4iWPqiG-it0qp5GFg@mail.gmail.com>
2020-09-05 18:57 ` Dmitry Osipenko [this message]
2020-09-12 0:50 ` Wang, Jiada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610b2513-7d62-386d-ed2a-54e1bea4df43@gmail.com \
--to=digetx@gmail.com \
--cc=Andrew_Gabbasov@mentor.com \
--cc=andy.shevchenko@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=jiada_wang@mentor.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).