From: Chris Ye <linzhao.ye@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Chris Ye <lzye@google.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
trivial@kernel.org,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v2] Input: Fix the HID usage of DPAD input event generation.
Date: Wed, 4 Nov 2020 09:13:50 -0800 [thread overview]
Message-ID: <62b486c3-6cbe-495e-7843-1cffb010a685@gmail.com> (raw)
In-Reply-To: <CAO-hwJK3EzeQbiPMy=8YAVp91nN6bMcAqqfzff+-6mti9PFMHQ@mail.gmail.com>
Hi Benjamin,
We are using hid driver to inject hid report for D-Pad and Hat
switch events, like:
[0x00, 0x00, 0x00, 0x00, 0x01, 0x80, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00],
Check the HID format dump from kernel, this will send a 0x1 on HID usage
GenericDesktop.HatSwitch.
Do you need me to help write the gamevice tests? I've not observed any
regression from my side, as this patch is very specific to usage
D-PadUp/Down/Left/Right.
Thanks!
Chris
On 11/3/20 9:36 AM, Benjamin Tissoires wrote:
> I can emulate events for X,Y,
> buttons,... but I am not sure how the gamepad sends the events for the
> Hat switch and the D-Pad together.
next prev parent reply other threads:[~2020-11-04 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 19:35 [PATCH v2] Input: Fix the HID usage of DPAD input event generation Chris Ye
2020-11-02 8:16 ` Benjamin Tissoires
2020-11-02 17:24 ` Chris Ye
2020-11-03 17:36 ` Benjamin Tissoires
2020-11-04 17:13 ` Chris Ye [this message]
2020-11-05 17:22 ` Chris Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b486c3-6cbe-495e-7843-1cffb010a685@gmail.com \
--to=linzhao.ye@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lzye@google.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).