linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: linux@simonmicro.de, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet
Date: Tue, 17 Nov 2020 16:05:10 +0100	[thread overview]
Message-ID: <672ddee0a276be7d34e01c665df20d1c8ad2b7d0.camel@hadess.net> (raw)
In-Reply-To: <20201117004253.27A5A27EFD@localhost>

On Mon, 2020-11-16 at 19:42 -0500, Simon Beginn wrote:
> The touchscreen on the Teclast x98 Pro is also mounted upside-down in
> relation to the display orientation. I added it also to the list of
> those devices. Verified it works on my device - this has not been
> tested with more users than myself...

Looks good to me, thanks.

Signed-off-by: Bastien Nocera <hadess@hadess.net>

> 
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index f8dd416c89b2..7668174b62ed 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -136,6 +136,16 @@ static const struct dmi_system_id
> rotated_screen[] = {
>                         DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
>                 },
>         },
> +       {
> +               .ident = "Teclast X98 Pro",
> +               .matches = {
> +                       /* Only match bios date, because the
> manufacturers bios
> +                        * does not report the board name at all
> (sometimes)...
> +                        */
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
> +                       DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"),
> +               },
> +       },
>         {
>                 .ident = "WinBook TW100",
>                 .matches = {



  reply	other threads:[~2020-11-17 15:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17  0:42 [PATCH] Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet Simon Beginn
2020-11-17 15:05 ` Bastien Nocera [this message]
2020-12-07 15:13   ` Bastien Nocera
2020-12-08  1:53     ` Dmitry Torokhov
     [not found]   ` <434f5579-5ca7-5f54-c853-af720769e1cc@simonmicro.de>
     [not found]     ` <5f9a868c166e13062a2109ab868f9e806aafc563.camel@hadess.net>
     [not found]       ` <111d63473070310b1576c633e4e5debac0a4b22f.camel@hadess.net>
     [not found]         ` <422df127-449f-247f-bb7e-005575dc23cd@simonmicro.de>
2020-12-11 22:36           ` Fwd: " Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=672ddee0a276be7d34e01c665df20d1c8ad2b7d0.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux@simonmicro.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).