From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F715C6FD18 for ; Wed, 29 Mar 2023 09:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbjC2J25 (ORCPT ); Wed, 29 Mar 2023 05:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjC2J24 (ORCPT ); Wed, 29 Mar 2023 05:28:56 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A0330FF; Wed, 29 Mar 2023 02:28:55 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 231AA219C7; Wed, 29 Mar 2023 09:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680082134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PWy6BhAqB0twK2rbrO71b3JtwEl2UDo3dmVSgkvr7Cs=; b=yJKl+oauleT3X+homnJ87/o0reKN+UgLYTpa+N83G1+/7VWAIkkzvFeM1d6NGDFlIwZn67 pszzc6K4uzfuumnfFb5GE57zAZd86bkQgeBbOiRKXOd/92VgqaJsaXszauFR+2xroE/Md+ 66i2zKtKcuenL5rN7P0W7QbAa8/I8k8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680082134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PWy6BhAqB0twK2rbrO71b3JtwEl2UDo3dmVSgkvr7Cs=; b=Qvte5u6895My3Gbzzs7efgm2R2sYAilCvUqwhCN4sH6JCte4KXz4Nq0MSGnCGQzClnutAB aqcFVwbmbR6hozAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E46E9138FF; Wed, 29 Mar 2023 09:28:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id j1RVNtUEJGTuBgAAMHmgww (envelope-from ); Wed, 29 Mar 2023 09:28:53 +0000 Date: Wed, 29 Mar 2023 11:28:53 +0200 Message-ID: <874jq3q52i.wl-tiwai@suse.de> From: Takashi Iwai To: Hans de Goede Cc: Takashi Iwai , Pali =?ISO-8859-1?Q?Roh=E1r?= , Dmitry Torokhov , regressions@lists.linux.dev, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [REGRESSION] wrong coord from Thinkpad TrackPoint since 6.2 kernel In-Reply-To: <3dec29bf-b772-d82d-fff9-6c8bcca5f464@redhat.com> References: <87h6u4otuc.wl-tiwai@suse.de> <3dec29bf-b772-d82d-fff9-6c8bcca5f464@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 29 Mar 2023 11:22:18 +0200, Hans de Goede wrote: > > Hi Takashi, > > On 3/29/23 10:16, Takashi Iwai wrote: > > Hi, > > > > we've received a bug report about Thinkpad TrackPoint (ALPS DualPoint > > Stick) on 6.2 kernel: > > https://bugzilla.opensuse.org/show_bug.cgi?id=1209805 > > > > The device reports the wrong values as the movements, e.g. sometimes a > > value such as 255, 254 or -255 is returned while usually it should be > > a smaller value like -1 or 2. > > > > The evtest on 6.2.x kernel shows the wrong values like: > > > > Event: time 1680037542.898747, type 2 (EV_REL), code 0 (REL_X), value 255 > > Event: time 1680037542.898747, -------------- SYN_REPORT ------------ > > Event: time 1680037543.145196, type 2 (EV_REL), code 0 (REL_X), value 1 > > Event: time 1680037543.145196, -------------- SYN_REPORT ------------ > > Event: time 1680037543.175087, type 2 (EV_REL), code 1 (REL_Y), value -255 > > Event: time 1680037543.175087, -------------- SYN_REPORT ------------ > > Event: time 1680037543.185421, type 2 (EV_REL), code 0 (REL_X), value 1 > > Event: time 1680037543.185421, type 2 (EV_REL), code 1 (REL_Y), value -255 > > Event: time 1680037543.185421, -------------- SYN_REPORT ------------ > > > > while 6.1.x kernel shows the correct values like: > > > > Event: time 1680037386.318058, type 2 (EV_REL), code 0 (REL_X), value -1 > > Event: time 1680037386.318058, type 2 (EV_REL), code 1 (REL_Y), value -1 > > Event: time 1680037386.318058, -------------- SYN_REPORT ------------ > > Event: time 1680037386.328087, type 2 (EV_REL), code 0 (REL_X), value -1 > > Event: time 1680037386.328087, type 2 (EV_REL), code 1 (REL_Y), value -1 > > Event: time 1680037386.328087, -------------- SYN_REPORT ------------ > > Event: time 1680037386.338046, type 2 (EV_REL), code 0 (REL_X), value -1 > > Event: time 1680037386.338046, type 2 (EV_REL), code 1 (REL_Y), value -2 > > Event: time 1680037386.338046, -------------- SYN_REPORT ------------ > > > > I couldn't see any relevant changes in alps.c between those versions, > > so this is likely a breakage in a lower layer. > > > > Could you guys take a look? > > I believe this is caused by the kernel now using -funsigned-char > everywhere and this should be fixed by this commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/commit/?h=for-linus&id=754ff5060daf5a1cf4474eff9b4edeb6c17ef7ab Ah, that makes sense! I'll build a test kernel with this fix and ask the reporter for testing. > And there is a similar issue in the focaltech touchpad driver: > > https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/commit/?h=for-linus&id=8980f190947ba29f23110408e712444884b74251 > > Dmitry, since this is hitting 6.2 users, perhaps you can send > a pull-req for your current for-linus branch to get the fix > on its way to stable ? That'll be great. Thanks! Takashi