From: Javier Martinez Canillas <javierm@redhat.com>
To: kernel test robot <lkp@intel.com>, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
"Enric Balletbo i Serra" <eballetbo@redhat.com>,
"Brendan Higgins" <brendanhiggins@google.com>,
linux-kselftest@vger.kernel.org,
"Maíra Canal" <mcanal@igalia.com>,
"David Gow" <davidgow@google.com>,
"Daniel Latypov" <dlatypov@google.com>,
kunit-dev@googlegroups.com, "Maxime Ripard" <maxime@cerno.tech>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: Add KUnit tests for some of the input core helper functions
Date: Thu, 30 Mar 2023 13:12:12 +0200 [thread overview]
Message-ID: <87a5zufq7n.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <202303301815.kRKFM3NH-lkp@intel.com>
kernel test robot <lkp@intel.com> writes:
Hello,
[...]
>
> All warnings (new ones prefixed by >>):
>
> drivers/clk/.kunitconfig: warning: ignored by one of the .gitignore files
> drivers/gpu/drm/tests/.kunitconfig: warning: ignored by one of the .gitignore files
> drivers/gpu/drm/vc4/tests/.kunitconfig: warning: ignored by one of the .gitignore files
> drivers/hid/.kunitconfig: warning: ignored by one of the .gitignore files
>>> drivers/input/tests/.kunitconfig: warning: ignored by one of the .gitignore files
KUnit folks, what should we do about this? I believe the correct thing
here would be for these dot-files to not be ignored by git.
Not only to prevent these reports, but also to avoid the need to add
them using `git add -f`, since is quite error prone and easy to miss.
I was thinking about posting the following patch:
From f1dc1733001682886458c23b676123635bc29da0 Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javierm@redhat.com>
Date: Thu, 30 Mar 2023 13:04:42 +0200
Subject: [PATCH] .gitignore: Exclude KUnit config dot-files
There's a rule to ignore all the dot-files (.*) but we want to exclude the
config files used by KUnit (.kunitconfig) since those are usually added to
allow executing test suites without having to enable custom config options.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 70ec6037fa7a..7f86e0837909 100644
--- a/.gitignore
+++ b/.gitignore
@@ -103,6 +103,7 @@ modules.order
!.get_maintainer.ignore
!.gitattributes
!.gitignore
+!.kunitconfig
!.mailmap
!.rustfmt.toml
base-commit: 197b6b60ae7bc51dd0814953c562833143b292aa
--
2.40.0
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-03-30 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 8:18 [PATCH v2] Input: Add KUnit tests for some of the input core helper functions Javier Martinez Canillas
2023-03-30 10:53 ` kernel test robot
2023-03-30 11:12 ` Javier Martinez Canillas [this message]
2023-03-30 16:00 ` Daniel Latypov
2023-04-02 5:47 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5zufq7n.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maxime@cerno.tech \
--cc=mcanal@igalia.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).