From: Kevin Hilman <khilman@deeprootsystems.com>
To: miguel.aguilar@ridgerun.com, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
nsnehaprabha@ti.com, linux-input@vger.kernel.org,
santiago.nunez@ridgerun.com, todd.fischer@ridgerun.com,
clark.becker@ridgerun.com
Subject: Re: [PATCH v2 1/2] Input: Add device_enable handler to DaVinci Keyscan platform data
Date: Mon, 07 Dec 2009 16:24:59 -0800 [thread overview]
Message-ID: <87hbs25n38.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1258141434-18351-1-git-send-email-miguel.aguilar@ridgerun.com> (miguel aguilar's message of "Fri\, 13 Nov 2009 13\:43\:54 -0600")
<miguel.aguilar@ridgerun.com> writes:
> From: Miguel Aguilar <miguel.aguilar@ridgerun.com>
>
> Add a function pointer in the platform data of the DaVinci Keyscan driver
> called device_enabled, in order to perform board specific actions when
> the device is initialized, like setup the PINMUX configuration.
>
> Signed-off-by: Miguel Aguilar <miguel.aguilar@ridgerun.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Dmitry,
Will you be queueing this driver (and this patch) for 2.6.34? I
thought you had accepted the original driver, but I don't see it in
the master or next branch of your input tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
Thanks or clarifying.
Kevin
> ---
> arch/arm/mach-davinci/include/mach/keyscan.h | 1 +
> drivers/input/keyboard/davinci_keyscan.c | 8 ++++++++
> 2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/include/mach/keyscan.h b/arch/arm/mach-davinci/include/mach/keyscan.h
> index b4e21a2..7a560e0 100644
> --- a/arch/arm/mach-davinci/include/mach/keyscan.h
> +++ b/arch/arm/mach-davinci/include/mach/keyscan.h
> @@ -29,6 +29,7 @@ enum davinci_matrix_types {
> };
>
> struct davinci_ks_platform_data {
> + int (*device_enable)(struct device *dev);
> unsigned short *keymap;
> u32 keymapsize;
> u8 rep:1;
> diff --git a/drivers/input/keyboard/davinci_keyscan.c b/drivers/input/keyboard/davinci_keyscan.c
> index 6e52d85..d410d7a 100644
> --- a/drivers/input/keyboard/davinci_keyscan.c
> +++ b/drivers/input/keyboard/davinci_keyscan.c
> @@ -174,6 +174,14 @@ static int __init davinci_ks_probe(struct platform_device *pdev)
> struct davinci_ks_platform_data *pdata = pdev->dev.platform_data;
> int error, i;
>
> + if (pdata->device_enable) {
> + error = pdata->device_enable(dev);
> + if (error < 0) {
> + dev_dbg(dev, "device enable function failed\n");
> + return error;
> + }
> + }
> +
> if (!pdata->keymap) {
> dev_dbg(dev, "no keymap from pdata\n");
> return -EINVAL;
> --
> 1.6.0.4
>
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
next prev parent reply other threads:[~2009-12-08 0:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 19:43 [PATCH v2 1/2] Input: Add device_enable handler to DaVinci Keyscan platform data miguel.aguilar
2009-11-19 2:59 ` Dmitry Torokhov
2009-11-19 16:32 ` Miguel Aguilar
2009-11-19 16:55 ` Dmitry Torokhov
2009-11-19 17:54 ` Miguel Aguilar
2009-11-19 20:33 ` Dmitry Torokhov
2009-11-19 20:59 ` Miguel Aguilar
2009-11-19 21:33 ` Narnakaje, Snehaprabha
2009-11-24 16:49 ` Miguel Aguilar
2009-12-01 17:08 ` Steve Chen
2009-12-08 0:24 ` Kevin Hilman [this message]
2009-12-08 0:48 ` Dmitry Torokhov
2009-12-08 1:05 ` Kevin Hilman
[not found] ` <877hsy46o0.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-01-06 0:21 ` Kevin Hilman
2010-01-06 8:26 ` Dmitry Torokhov
2010-01-06 17:04 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbs25n38.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=clark.becker@ridgerun.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=miguel.aguilar@ridgerun.com \
--cc=nsnehaprabha@ti.com \
--cc=santiago.nunez@ridgerun.com \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).